Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Expose some of the staking miner types over metadata #12245

Merged
merged 2 commits into from
Sep 12, 2022
Merged

Expose some of the staking miner types over metadata #12245

merged 2 commits into from
Sep 12, 2022

Conversation

kianenigma
Copy link
Contributor

Simply adds back some of these types that have been moved from trait Config to trait MinerConfig to the metadata.

@kianenigma kianenigma added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. labels Sep 12, 2022
@kianenigma kianenigma mentioned this pull request Sep 12, 2022
Closed
BustaNit
BustaNit approved these changes Sep 12, 2022
View reviewed changes
Copy link
Contributor

@BustaNit BustaNit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

frame/election-provider-multi-phase/src/lib.rs Outdated Show resolved Hide resolved
@kianenigma
Copy link
Contributor Author

bot merge

@paritytech-processbot paritytech-processbot bot merged commit dd1f1b5 into master Sep 12, 2022
@paritytech-processbot paritytech-processbot bot deleted the kiz-expose-miner-types-over-metadata branch September 12, 2022 18:10
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
@kianenigma @BustaNit @ark0f
Expose some of the staking miner types over metadata (paritytech#12245)
95f9fd7 
* Expose some of the staking miner types over metadata

* Update frame/election-provider-multi-phase/src/lib.rs

Co-authored-by: Emily Ostbo <[email protected]>

Co-authored-by: Emily Ostbo <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wpank wpank wpank approved these changes

@BustaNit BustaNit BustaNit approved these changes

@niklasad1 niklasad1 niklasad1 approved these changes

@sam0x17 sam0x17 sam0x17 approved these changes

@ggwpez ggwpez Awaiting requested review from ggwpez

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit.
Projects
(Nominated) Proof of Stake
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kianenigma @sam0x17 @wpank @niklasad1 @BustaNit