This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Don't run cargo-check-benches for master based downstream staging pipelines
#12233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcny
added
A0-please_review
sergejparity
approved these changes
Sep 12, 2022
altaua
approved these changes
Sep 12, 2022
radupopa2010
approved these changes
Sep 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running downstream pipelines for
masterwith images other than the current production one could result in incorrectnode-benchresults andnode-bench-regression-guard's false positives. This behavior could happen because of e.g. different stable Rust toolchains in these images. Any successfulcargo-check-benchesjob (i.e. it doesn't matter if it was run with e.g.ci-linux:stagingorci-linux:production) will upload its results and this can result in incorrect performance regression detections.