Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Update contract weights #12192

Merged
merged 3 commits into from
Sep 7, 2022
Merged

Update contract weights #12192

merged 3 commits into from
Sep 7, 2022

Conversation

athei
Copy link
Member

@athei athei commented Sep 6, 2022 •
edited
Loading

They weren't updated after recent PRs.

@athei
Copy link
Member Author

athei commented Sep 6, 2022

/cmd queue -c bench-bot $ pallet dev pallet_contracts

@command-bot
Copy link

command-bot bot commented Sep 6, 2022 •
edited
Loading

@athei https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1814227 was started for your command "$PIPELINE_SCRIPTS_DIR/bench-bot.sh" pallet dev pallet_contracts. Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment /cmd cancel 48-d425d7bb-ab87-48e8-b21d-500013742a13 to cancel this command or /cmd cancel to cancel all commands in this pull request.

@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Sep 6, 2022
@command-bot
Copy link

command-bot bot commented Sep 6, 2022

@athei Command "$PIPELINE_SCRIPTS_DIR/bench-bot.sh" pallet dev pallet_contracts has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1814227 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1814227/artifacts/download.

@athei athei added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit Z0-trivial Writing the issue is of the same difficulty as patching the code. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). and removed Z0-trivial Writing the issue is of the same difficulty as patching the code. A0-please_review Pull request needs code review. labels Sep 7, 2022
ggwpez
ggwpez reviewed Sep 7, 2022
View reviewed changes
frame/contracts/src/weights.rs
.saturating_add(T::DbWeight::get().reads(1 as u64))
.saturating_add(T::DbWeight::get().writes(3 as u64))
Weight::from_ref_time(37_011_000 as u64)
.saturating_add(T::DbWeight::get().reads(2 as u64))
Copy link
Member

@ggwpez ggwpez Sep 7, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are storage count changes, so the weights were definitely out-dated.

Copy link
Member Author

@athei athei Sep 7, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. This was the PR that added topics to the event. Hmm topics are pretty expensive cause the are counted as normal storage writes even though they never touch storage.

@athei
Copy link
Member Author

athei commented Sep 7, 2022

bot merge

@paritytech-processbot
Copy link

Error: Checks failed for 40b8f69

@athei athei merged commit 021f712 into master Sep 7, 2022
@athei athei deleted the at/contract-weights branch September 7, 2022 13:49
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
@athei @ark0f
Update contract weights (paritytech#12192)
2823959 
* Dummy commit

* ".git/.scripts/bench-bot.sh" pallet dev pallet_contracts

Co-authored-by: command-bot <>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ggwpez ggwpez ggwpez approved these changes

@agryaznov agryaznov agryaznov approved these changes

Assignees
No one assigned
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
Smart Contracts
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@athei @agryaznov @ggwpez