Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Remove unnecessary allocations when crossing WASM FFI boundary #10191

Merged
merged 1 commit into from
Nov 5, 2021
Merged

Remove unnecessary allocations when crossing WASM FFI boundary #10191

merged 1 commit into from
Nov 5, 2021

Conversation

koute
Copy link
Contributor

@koute koute commented Nov 5, 2021

Saw this pop up when profiling; probably doesn't actually matter in practice, but it is an easy enough fix nevertheless.

@koute koute added A0-please_review Pull request needs code review. I9-optimisation An enhancement to provide better overall performance in terms of time-to-completion for a task. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Nov 5, 2021
@koute koute requested review from gilescope and bkchr November 5, 2021 09:31
gilescope
gilescope approved these changes Nov 5, 2021
View reviewed changes
Copy link
Contributor

@gilescope gilescope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@koute
Copy link
Contributor Author

koute commented Nov 5, 2021

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 8439a0b into paritytech:master Nov 5, 2021
@github-actions github-actions bot mentioned this pull request Dec 2, 2021
Closed
grishasobol pushed a commit to gear-tech/substrate that referenced this pull request Mar 28, 2022
@koute @grishasobol
Remove unnecessary allocations when crossing WASM FFI boundary (parit…
c59b607 
…ytech#10191)
@koute koute mentioned this pull request Sep 29, 2022
Merged
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
@koute @ark0f
Remove unnecessary allocations when crossing WASM FFI boundary (parit…
a7b754a 
…ytech#10191)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bkchr bkchr bkchr approved these changes

@gilescope gilescope gilescope approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit I9-optimisation An enhancement to provide better overall performance in terms of time-to-completion for a task.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@koute @gilescope @bkchr