Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Refactor node-cli "integration tests" #9773

Closed
bkchr opened this issue Sep 14, 2021 · 0 comments · Fixed by #9848
Closed

Refactor node-cli "integration tests" #9773

bkchr opened this issue Sep 14, 2021 · 0 comments · Fixed by #9848
Assignees
Labels
I5-tests Tests need fixing, improving or augmenting. I7-refactor Code needs refactoring.

Comments

@bkchr
Copy link
Member

bkchr commented Sep 14, 2021

The following tests: https://github.com/paritytech/substrate/tree/master/bin/node/cli/tests often fail in CI. The problem is that they use sleep (there are other usages of sleep as well). We should remove most of these sleep calls, as they are relative bad on CI where it can happen that the system is overloaded. Instead of sleeping we should use the rpc to communicate with the node and to make sure that it produced X block for example where X is some small number like 3. This way we wait a little bit longer when the CI is overload, but we not fail with a spurious error.

Similar tests also exist in Cumulus and could use the same love afterwards.

@bkchr bkchr added I5-tests Tests need fixing, improving or augmenting. I7-refactor Code needs refactoring. labels Sep 14, 2021
@gilescope gilescope mentioned this issue Sep 23, 2021
@ghost ghost closed this as completed in #9848 Sep 29, 2021
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
I5-tests Tests need fixing, improving or augmenting. I7-refactor Code needs refactoring.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants