Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

pallet-balances may not be the only provider #9375

Closed
xlc opened this issue Jul 19, 2021 · 1 comment
Closed

pallet-balances may not be the only provider #9375

xlc opened this issue Jul 19, 2021 · 1 comment
Labels
I3-bug The node fails to follow expected behavior.

Comments

@xlc
Copy link
Contributor

xlc commented Jul 19, 2021

// TODO: This is over-conservative. There may now be other providers, and this pallet
// may not even be a provider.
let allow_death = existence_requirement == ExistenceRequirement::AllowDeath;
let allow_death = allow_death && !system::Pallet::<T>::is_provider_required(transactor);

It should be using can_dec_provider instead of is_provider_required.

Also need to have some tests to cover the case where pallet-balances is not the only provider. Or if there are multiple instances of it.

@bkchr bkchr added the I3-bug The node fails to follow expected behavior. label Jul 19, 2021
@shaunxw
Copy link
Contributor

shaunxw commented Aug 9, 2021

I think it could be closed now with #9411 merged.

@xlc xlc closed this as completed Aug 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
I3-bug The node fails to follow expected behavior.
Projects
None yet
Development

No branches or pull requests

3 participants