Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Consider Upgrading wasmtime #7989

Closed
apopiak opened this issue Jan 26, 2021 · 5 comments · Fixed by #7865
Closed

Consider Upgrading wasmtime #7989

apopiak opened this issue Jan 26, 2021 · 5 comments · Fixed by #7865
Assignees

Comments

@apopiak
Copy link
Contributor

apopiak commented Jan 26, 2021

bytecodealliance/wasmtime#2575 keeps substrate from building on Apple M1s apparently.
I checked and it's part of the 0.22 release.

@apopiak
Copy link
Contributor Author

apopiak commented Jan 26, 2021

depends on bytecodealliance/wasmtime#2605

@tomaka
Copy link
Contributor

tomaka commented Jan 29, 2021

#7865
It's waiting for someone to fix the compilation errors.

Last PR was back in November, and nobody did it: #7587

@athei
Copy link
Member

athei commented Feb 3, 2021

Would I just push the fixing commits to the dependabot branch? I am asking because it seems to rebase onto master by force pushing.

@tomaka
Copy link
Contributor

tomaka commented Feb 3, 2021

It stops force-pushing if you push on its branch

@athei athei self-assigned this Feb 3, 2021
@athei athei linked a pull request Feb 3, 2021 that will close this issue
@jak-pan
Copy link
Contributor

jak-pan commented Feb 5, 2021

This won't help yet.

I've tried to compile with the v0.22.1 tag from the Github repo and it's still not fixed there.
Building with latest main branch worked so we'll need to wait still for next version I think.

For fully working M1 build we'll also need to fix/update libsrockdb-sys though which is tracked here facebook/rocksdb#7714 (I've successfully compiled Substrate using https://github.com/hdevalence/rust-rocksdb as another override)

@ghost ghost closed this as completed in #7865 Feb 8, 2021
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants