Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

The DHT contains dialing ports #747

Closed
tomaka opened this issue Sep 14, 2018 · 1 comment
Closed

The DHT contains dialing ports #747

tomaka opened this issue Sep 14, 2018 · 1 comment
Labels
I3-bug The node fails to follow expected behavior.
Milestone
Ideas

Comments

@tomaka
Copy link
Contributor

tomaka commented Sep 14, 2018

When we successfully connect to a node, we add the address of that node to the topology. However we add the TCP dialing port, which doesn't make sense in this context.
@gavofyork gavofyork added this to the As-and-when milestone Sep 16, 2018
@gavofyork gavofyork added the I3-bug The node fails to follow expected behavior. label Sep 17, 2018
@tomaka tomaka mentioned this issue Sep 21, 2018
Merged
@tomaka
Copy link
Contributor Author

tomaka commented Sep 26, 2018

Fixed in #742

@tomaka tomaka closed this as completed Sep 26, 2018
lamafab pushed a commit to lamafab/substrate that referenced this issue Jun 16, 2020
@gavofyork
Bump Substrate & versions (paritytech#747)
f570356 
* Bump versions

* Update for tipping treasury

* Bump substrate

* Fixes

* Put send_consensus back in.

* Fix test

* Fixes

* Fixes

* Fix warning
liuchengxu pushed a commit to chainx-org/substrate that referenced this issue Aug 23, 2021
@toxotguo @atenjin
fix check_withdraw_tx (paritytech#747)
b683d10 
* fix check_withdraw_tx

* fix compare
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
I3-bug The node fails to follow expected behavior.
Projects
None yet
Milestone
Ideas
Development

No branches or pull requests
2 participants
@gavofyork @tomaka