Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Naming conflict two transaction versions with different values. #7255

Closed
darkfriend77 opened this issue Oct 3, 2020 · 0 comments · Fixed by #7258
Closed

Naming conflict two transaction versions with different values. #7255

darkfriend77 opened this issue Oct 3, 2020 · 0 comments · Fixed by #7258
Labels
J2-unconfirmed Issue might be valid, but it’s not yet known.

Comments

@darkfriend77
Copy link

transaction_version

transaction_version: 1,

const TRANSACTION_VERSION: u8 = 4;

const TRANSACTION_VERSION: u8 = 4;

Why do they have the same name? One is used for the extrinsic start and the other one is used in the payload, so both are represented in the submitextrinsic byte string.

I would suggest to either rename the one in the unchecked_extrinsic or to unify them.

@github-actions github-actions bot added the J2-unconfirmed Issue might be valid, but it’s not yet known. label Oct 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
J2-unconfirmed Issue might be valid, but it’s not yet known.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant