Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

How do nominators ranking after MaxNominatorRewardedPerValidator receive their rewards? #7002

Closed
cryptomancc opened this issue Sep 1, 2020 · 6 comments
Labels
J2-unconfirmed Issue might be valid, but it’s not yet known.

Comments

@cryptomancc
Copy link

In the Lazy Payout(#4474 ) implemention, the reward is limited to the T::MaxNominatorRewardedPerValidator biggest nominators, where will the leftover rewards go? And how do nominators ranking after MaxNominatorRewardedPerValidator receive their rewards?

@github-actions github-actions bot added the J2-unconfirmed Issue might be valid, but it’s not yet known. label Sep 1, 2020
@cryptomancc
Copy link
Author

cryptomancc commented Sep 1, 2020

And there is a similar question, while appling Staking::clear_era_information, if the rewards are not cliamed, where will they go? As far as I know from the source code(v2.0.0-rc6), the unclaimed rewards will disappear, is that a feature?

@gui1117
Copy link
Contributor

gui1117 commented Sep 2, 2020

In the Lazy Payout(#4474 ) implemention, the reward is limited to the T::MaxNominatorRewardedPerValidator biggest nominators, where will the leftover rewards go? And how do nominators ranking after MaxNominatorRewardedPerValidator receive their rewards?

the staking doc says:

Rewards must be claimed for each era before it gets too old by $HISTORY_DEPTH using the
payout_stakers call. Any account can call payout_stakers, which pays the reward to the
validator as well as its nominators. Only the [Trait::MaxNominatorRewardedPerValidator]
biggest stakers can claim their reward. This is to limit the i/o cost to mutate storage for each
nominator's account.

so nominators ranking after MaxNominatorRewardedPerValidator have no reward

@gui1117
Copy link
Contributor

gui1117 commented Sep 2, 2020

And there is a similar question, while appling Staking::clear_era_information, if the rewards are not cliamed, where will they go? As far as I know from the source code(v2.0.0-rc6), the unclaimed rewards will disappear, is that a feature?

I confirm unclaimed reward disappear. the current process of having stakers claiming their rewards is because claiming all of them in one block cost too much.
Still maybe we can think of some automation like: claim reward of one staker per block automatically. But I think the preferred direction is to have it claimed not by the chain, maybe some notification tool like mail service or push service could be made here for stakers.

@bkchr
Copy link
Member

bkchr commented Sep 8, 2020

CC @shawntabrizi @kianenigma

@kianenigma
Copy link
Contributor

FYI we are working on the process of increasing the limit
paritytech/polkadot#1668
#7007

The rest are answered correctly as far as see by @thiolliere.

@gui1117
Copy link
Contributor

gui1117 commented Sep 8, 2020

I think the issue is answered, if you want to request having unclaimed era into treasury or something configurable, feel free to open another issue

@gui1117 gui1117 closed this as completed Sep 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
J2-unconfirmed Issue might be valid, but it’s not yet known.
Projects
None yet
Development

No branches or pull requests

4 participants