Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Remove sleep in import_blocks command #6115

Closed
pscott opened this issue May 22, 2020 · 0 comments · Fixed by #6124
Closed

Remove sleep in import_blocks command #6115

pscott opened this issue May 22, 2020 · 0 comments · Fixed by #6124
Assignees
@pscott
Labels
B0-silent Changes should not be mentioned in any release notes J0-enhancement An additional feature request. U1-asap No need to stop dead in your tracks, however issue should be addressed as soon as possible.

Comments

@pscott
Copy link
Contributor

pscott commented May 22, 2020

#5816 made some significant changes to the import_blocks command, but introduced a thread::sleep() in an async IO environment.

We need to remove this piece of code and replace it with a better approach (maybe using WaitLink to wake up the waker?)
@pscott pscott added J0-enhancement An additional feature request. U1-asap No need to stop dead in your tracks, however issue should be addressed as soon as possible. B0-silent Changes should not be mentioned in any release notes labels May 22, 2020
@pscott pscott self-assigned this May 22, 2020
@pscott pscott mentioned this issue May 25, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pscott pscott

Labels
B0-silent Changes should not be mentioned in any release notes J0-enhancement An additional feature request. U1-asap No need to stop dead in your tracks, however issue should be addressed as soon as possible.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove sleep in import blocks paritytech/substrate
1 participant
@pscott