Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Get rid of unbounded queues #6096

Open
gnunicorn opened this issue May 21, 2020 · 2 comments
Open

Get rid of unbounded queues #6096

gnunicorn opened this issue May 21, 2020 · 2 comments
Labels
I8-footprint An enhancement to provide a smaller (system load, memory, network or disk) footprint. J0-enhancement An additional feature request.

Comments

@gnunicorn
Copy link
Contributor

Unbounded queues are hard to proof to not leak, and even if that was done once, if the code around that changes, the assumption might break and we don't know – other than when we have a faulty assumption in an expect().

Instead of unbounded queues, we should use channels, futures and actual async code that allows for backpressure to happen rather than continuously fill a buffer.
@gnunicorn gnunicorn added I8-footprint An enhancement to provide a smaller (system load, memory, network or disk) footprint. J0-enhancement An additional feature request. labels May 21, 2020
@gnunicorn gnunicorn mentioned this issue May 21, 2020
Open
@tomaka
Copy link
Contributor

tomaka commented May 21, 2020

cc #3230 #5481

@tomaka
Copy link
Contributor

tomaka commented May 21, 2020 •
edited
Loading

While this is obviously a noble goal, many of these unbounded channel involve an epic refactoring.

@expenses expenses mentioned this issue Jun 4, 2020
Merged
@lexnv lexnv mentioned this issue Jun 16, 2022
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
I8-footprint An enhancement to provide a smaller (system load, memory, network or disk) footprint. J0-enhancement An additional feature request.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gnunicorn @tomaka