-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Panic on invalid unsigned phragmen solution #5980
Comments
related: #4517 (comment) Yeah now with proper weight refund perhaps this is less of a security issue. But still, no change allows each block author to submit any potentially a garbage solution with no consequence. Even if we refund, this is taking everyone's time. Moreover, they can submit a garbage solution that will not be refunded, and will be rejected due to an issue at the very end (i.e. bogus score). This allows validators to mess with the chain with no consequence, and again waste everyone's time. Still, you can argue that if they do this, then they will have less weight to pack other transactions in the block, hence they will gain less profit. But I don't think this is a strong enough guarantee. Panic would disincentivize this because they lose their entire authoring block. I won't run into this issue, but I think it should be closed long term once we have a stabilised offchain phragmen pipeline and it has been battle tested. |
Panic where? In the extrinsic? |
yeah. |
We don't have a mechanism that invalidates a full block on panic of an extrinsic ^^ |
I think what Gav meant was during import: a transaction panics in block import, then this invalidates the whole block no? |
Ahh yes that is correct. |
Once #6173 is merged, if we no longer have invalid unsigned solutions, this will be patched thereafter. |
I've been doing more analysis after #6173 and we seem to be doing well. I will soon fix this. |
substrate/frame/staking/src/lib.rs
Lines 1909 to 1920 in 3fe26e6
The text was updated successfully, but these errors were encountered: