Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Name event parameters #5913

Closed
xlc opened this issue May 5, 2020 · 1 comment · Fixed by #6877
Closed

Name event parameters #5913

xlc opened this issue May 5, 2020 · 1 comment · Fixed by #6877
Labels
J0-enhancement An additional feature request.

Comments

@xlc
Copy link
Contributor

xlc commented May 5, 2020

Currently event parameters are unnamed, so the only way to know the meaning of each value is by looking at the type and docs.

It will be good if there is a way annotate the parameter name in metadata so SDK can generate named accessor.

For now we are going to try to parse the doc comments to look something like (from, to, value) to get the name, but it does not always work.

/// Transfer succeeded (from, to, value).

@xlc xlc changed the title Name event parameters named Name event parameters May 5, 2020
@bkchr bkchr added the J0-enhancement An additional feature request. label May 6, 2020
@bkchr
Copy link
Member

bkchr commented May 6, 2020

This can come with #5678

This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
J0-enhancement An additional feature request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants