Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

ValidatorPrefs Updates Should Apply at Next Era #4220

Closed
joepetrowski opened this issue Nov 27, 2019 · 4 comments
Closed

ValidatorPrefs Updates Should Apply at Next Era #4220

joepetrowski opened this issue Nov 27, 2019 · 4 comments
Assignees
Labels
I3-bug The node fails to follow expected behavior.

Comments

@joepetrowski
Copy link
Contributor

If a current validator issues staking::validate() with new ValidatorPrefs, the effects are felt immediately. That is, the validator can change their commission mid-era and take the rewards from their nominators.

Related: #4121

@joepetrowski joepetrowski added the I3-bug The node fails to follow expected behavior. label Nov 27, 2019
@gui1117 gui1117 mentioned this issue Dec 10, 2019
4 tasks
@gui1117 gui1117 self-assigned this Dec 10, 2019
@gui1117
Copy link
Contributor

gui1117 commented Jan 10, 2020

if we fix this and allow the validator to change the preference only for future era is that enough ?
I can imagine a validator changing the preference just before a new era is planned, thus no nominators will have the time to change their nomination.

@joepetrowski
Copy link
Contributor Author

Validators will probably be more advanced and diligent than nominators, so they definitely could pull this off. That said, hopefully their nominators would only suffer one era of lost rewards and would then choose a different validator. Perhaps something for the research team to chime in on whether changes should apply in era n + 1 or n + 2.

CC @burdges @AlistairStewart

@burdges
Copy link

burdges commented Jan 10, 2020

As you like, another option is era n+1 but only if the transaction appears before the final epoch of era n, after that it's n+2.

@gui1117
Copy link
Contributor

gui1117 commented Mar 12, 2020

Due to #4474 ValidatorPrefs indeed apply at next era. though there is no delay for nominators to know this preference ahead of time (a validator can change its preference just before the new era)

@gui1117 gui1117 closed this as completed Mar 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
I3-bug The node fails to follow expected behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants