Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Topic-aware consensus-gossip pruning #1646

Closed
rphmeier opened this issue Jan 31, 2019 · 0 comments · Fixed by #1658
Closed

Topic-aware consensus-gossip pruning #1646

rphmeier opened this issue Jan 31, 2019 · 0 comments · Fixed by #1658
Assignees
@andresilva
Labels
I9-optimisation An enhancement to provide better overall performance in terms of time-to-completion for a task. Z2-medium Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase.
Milestone
1.1

Comments

@rphmeier
Copy link
Contributor

Related to #1645

Consensus gossip (network/consensus_gossip.rs) should maintain an LRU cache of "known dead" topics. There should be a collect_garbage variant specifically for removing all messages on a specific topic.

received messages for a dead topic should be rejected.
All current uses of collect_garbage should be amended where possible to use the new variant.
@rphmeier rphmeier added I9-optimisation An enhancement to provide better overall performance in terms of time-to-completion for a task. Z2-medium Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase. labels Jan 31, 2019
@rphmeier rphmeier added this to the 1.0 (final) milestone Jan 31, 2019
@andresilva andresilva self-assigned this Feb 1, 2019
@andresilva andresilva mentioned this issue Feb 1, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@andresilva andresilva

Labels
I9-optimisation An enhancement to provide better overall performance in terms of time-to-completion for a task. Z2-medium Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase.
Projects
None yet
Milestone
1.1
Development

Successfully merging a pull request may close this issue.

Reduce consensus spam paritytech/substrate
2 participants
@andresilva @rphmeier