Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

try-runtime: execute a range of past blocks #13840

Closed
kianenigma opened this issue Apr 6, 2023 · 2 comments
Closed

try-runtime: execute a range of past blocks #13840

kianenigma opened this issue Apr 6, 2023 · 2 comments
Labels
J0-enhancement An additional feature request. T1-runtime This PR/Issue is related to the topic “runtime”. Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder Z6-mentor An easy task where a mentor is available. Please indicate in the issue who the mentor could be.

Comments

@kianenigma
Copy link
Contributor

An extension to the existing execute-block that, instead of re-executing one block, it executes a range of past blocks, as long as they are one continuous range.

Should be tested with the new testing infra added in #13794.

@kianenigma kianenigma added J0-enhancement An additional feature request. Z6-mentor An easy task where a mentor is available. Please indicate in the issue who the mentor could be. Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder labels Apr 6, 2023
@PieWol
Copy link

PieWol commented Apr 11, 2023

Hey, I would really like to work on this issue but my experience in try-runtime is absolutely zero. This looks like you want a new fn in the impl frame_try_runtime::TryRuntime<Block> for Runtime codeblock that takes a range of blocks as an argument instead of the single block as execute_block does. Is that correct? So it would be a simple wrapper function using the already existing execute_block fn. I'll just try to figure out a correct way to implement that function so it is available via the cli. Regarding the continous range, does it mean the new fn should check for the user that every block is in the correct order so a failure would be detectable before the actual execution?

@liamaharon liamaharon moved this from Backlog to To Do in Runtime / FRAME Apr 12, 2023
@liamaharon liamaharon moved this from To Do to Backlog in Runtime / FRAME Apr 12, 2023
@juangirini juangirini added the T1-runtime This PR/Issue is related to the topic “runtime”. label Jun 7, 2023
@liamaharon
Copy link
Contributor

Moved to paritytech/try-runtime-cli#11

@github-project-automation github-project-automation bot moved this from Backlog to Done in Runtime / FRAME Aug 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
J0-enhancement An additional feature request. T1-runtime This PR/Issue is related to the topic “runtime”. Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder Z6-mentor An easy task where a mentor is available. Please indicate in the issue who the mentor could be.
Projects
Status: Done
Development

No branches or pull requests

4 participants