Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Add an integration test for warp sync #11471

Closed
arkpar opened this issue May 19, 2022 · 1 comment · Fixed by #12675
Closed

Add an integration test for warp sync #11471

arkpar opened this issue May 19, 2022 · 1 comment · Fixed by #12675
Assignees
Labels
J0-enhancement An additional feature request. Z2-medium Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase.

Comments

@arkpar
Copy link
Member

arkpar commented May 19, 2022

Warp sync is not fully covered by tests, requiring manual testing on each release. There are unit tests in sc-network-test that test the warp sync protocol, but they don't cover ineractions with BABE and GRANDPA after the sync is complete. So a more real-life test is required, probably on the sc-service level, where we already have integration tests for sync and basic block authoring/consensus.

The challenge here is that to properly test warp sync we need at least some changes to the GRANPA authority set and BABE epochs and current testing framework does not allow to simulate that.

@arkpar arkpar added J0-enhancement An additional feature request. Z2-medium Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase. labels May 19, 2022
@bkchr
Copy link
Member

bkchr commented May 19, 2022

We should probably write a zombienet based test for this. We probably need some kind of chain restore. For that we need to be able to skip Babe epochs to not fail with the famous "unexpected epoch change error". I think @andresilva has some ideas for that?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
J0-enhancement An additional feature request. Z2-medium Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants