Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

nomination-pools: Make max points to balance ratio configurable #10792

Closed
emostov opened this issue Feb 4, 2022 · 4 comments · Fixed by #11377
Closed

nomination-pools: Make max points to balance ratio configurable #10792

emostov opened this issue Feb 4, 2022 · 4 comments · Fixed by #11377
Assignees
Labels
Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder Z6-mentor An easy task where a mentor is available. Please indicate in the issue who the mentor could be.

Comments

@emostov
Copy link
Contributor

emostov commented Feb 4, 2022

When a delegator attempts to join a nomination pool we ensure that the current points to balance ratio of the pool is less than 10. Instead of 10 this should be a pallet config option.

Should wait until #10694 is merged to start working on this.

Originally posted by @kianenigma in #10694 (comment)

@emostov emostov added Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder Z6-mentor An easy task where a mentor is available. Please indicate in the issue who the mentor could be. labels Feb 4, 2022
@emostov emostov mentioned this issue Feb 4, 2022
4 tasks
@Doordashcon
Copy link
Contributor

Hello @emostov I want to attempt this issue

@emostov
Copy link
Contributor Author

emostov commented Feb 21, 2022

Hi @Doordashcon - thank you for the interest in contributing. Unfortunately I initially miss-wrote this issue because I failed to mention that work for a PR addressing this issue should only start after #10694 is merged. Feel free to follow up after that.

@kianenigma
Copy link
Contributor

@emostov provide a bit more context here, if any? I think this will be a good candidate for @rossbulat to tackle.

@rossbulat
Copy link

rossbulat commented Apr 13, 2022

Thank you @kianenigma , awaiting #10694 before implementing.

For reference, logic to be amended once the config item is introduced:

lib.rs: ensure at 598.

tests.rs: asserts at 197, 201 and 490.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder Z6-mentor An easy task where a mentor is available. Please indicate in the issue who the mentor could be.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants