Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Support rust 2021? #10084

Closed
Dengjianping opened this issue Oct 22, 2021 · 2 comments · Fixed by #10170
Closed

Support rust 2021? #10084

Dengjianping opened this issue Oct 22, 2021 · 2 comments · Fixed by #10170
Labels
Z7-question Issue is a question. Closer should answer.

Comments

@Dengjianping
Copy link
Contributor

I'm trying to migrate project from rust 2018 to 2021, but it seems there're some problems on compiling.
Errors like

--> node/src/chain_specs/mod.rs:48:59
   |
48 | #[derive(Debug, Clone, PartialEq, Serialize, Deserialize, ChainSpecGroup, ChainSpecExtension)]
   |                                                           ^^^^^^^^^^^^^^ help: use `dyn`: `<dyn ChainSpecGroup>`
   |
   = note: this error originates in the derive macro `ChainSpecExtension` (in Nightly builds, run with -Z macro-backtrace for more info)
@nuke-web3
Copy link
Contributor

nuke-web3 commented Oct 22, 2021

Are you building master here? What commit is your Cargo.lock pointing to of Substrate dependencies?
If supported, I would think you need a very recent commit of this project to get the update you need, please try first to update to the HEAD of master 🙏

@nuke-web3 nuke-web3 added the Z7-question Issue is a question. Closer should answer. label Oct 22, 2021
@KiChjang
Copy link
Contributor

This actually looks like that one of the trait objects in the ChainSpecGroup derive macro did not use the proper dyn Trait syntax. It does require a fix on substrate. I'm going to try and reproduce this and send a PR soon.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Z7-question Issue is a question. Closer should answer.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants