Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Remove Google Analytics from rust docs #10017

Closed
nuke-web3 opened this issue Oct 12, 2021 · 1 comment · Fixed by #10091
Closed

Remove Google Analytics from rust docs #10017

nuke-web3 opened this issue Oct 12, 2021 · 1 comment · Fixed by #10091
Labels
Z7-question Issue is a question. Closer should answer.

Comments

@nuke-web3
Copy link
Contributor

nuke-web3 commented Oct 12, 2021

Originally posted by @imadarai in #10007 (comment)

The only remaining old devhub links are in https://github.com/paritytech/substrate/blob/master/.maintain/rustdoc-header.html I am asking @imadarai to check in on if these need to be migrated, can be added into this PR or a followup.


Does this header gets applied to all the rust-docs or just substrate?

I'd like to remove Google Analytics and update the script with Simple Analytics (cookie-less), but will need the exact links where it's being used.

This is unclear to me - what steps need to be taken to move forward?

@nuke-web3 nuke-web3 added the Z7-question Issue is a question. Closer should answer. label Oct 12, 2021
@nuke-web3
Copy link
Contributor Author

nuke-web3 commented Oct 23, 2021

The file can be removed as the style links are broken now too. Unless the team explicitly relies on this for whatever reason, and this line as well:

<script defer type="text/javascript" src="https://substrate.dev/js/config.js"></script>
<script defer type="text/javascript" src="https://substrate.dev/js/klaro.min.js"></script>
<script async type="opt-in" data-type="application/javascript"
data-src="https://www.googletagmanager.com/gtag/js?id=UA-145158313-2" data-name="googleAnalytics"></script>
<script type="opt-in" data-type="application/javascript" data-name="googleAnalytics">
window.dataLayer = window.dataLayer || [];
function gtag(){dataLayer.push(arguments);}
gtag('js', new Date());
gtag('config', 'UA-145158313-2');
</script>

- RUSTDOCFLAGS="--html-in-header $(pwd)/.maintain/rustdoc-header.html"

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Z7-question Issue is a question. Closer should answer.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant