Parachain multiplexing #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvdplm
reviewed
Nov 2, 2020
backend/src/node/connector.rs
Outdated
Comment on lines
28
to
35
| backlog: Vec<NodeMessage>, | ||
| backlogs: BTreeMap<ConnId, Vec<NodeMessage>>, |
There was a problem hiding this comment.
Unrelated to this PR, but is it ok that the backlog is unbounded? Maybe we could re-work this into a bounded queue?
EDIT: I see it is bounded to 10 below. Let's document that.
There was a problem hiding this comment.
Yeah, it's bounded. I'm more worried about the number of ConnId being unbounded atm.
dvdplm
reviewed
Nov 4, 2020
| backlog.remove(0); | ||
| } | ||
|
|
||
| backlog.push(msg); |
There was a problem hiding this comment.
The issue was that I had a separate backlog and Addr<Chain> per ConnId, but was using a single NodeId. Now the NodeId is tied to ConnId, everything else (using the enum for ConnMultiplex) is a refactor to make the intent clearer, and to avoid having 3 separate BTreeMaps for no good reason (one for chain address, one for backlog, one for node id).
dvdplm
approved these changes
Dec 16, 2020
insipx
approved these changes
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR to paritytech/substrate#7463
Expects
idfield on messages (defaults to0if absent), messages sent with differentids are treated as separate connections and can push the node to different chains.Unrelated: fixed continuation frames that sometimes errors on current build.