Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have some kind of bot that automatically updates chain specs with new checkpoints #739

Open
tomaka opened this issue Feb 10, 2022 · 6 comments
Labels

Comments

@tomaka
Copy link
Contributor

tomaka commented Feb 10, 2022

As part of #543, we need an automated way to update the checkpoint found in the chain specifications found in this repo.

I would suggest having a script automatically open pull requests, and maybe a GitHub workflow merging them automatically after verifying that the author is correct and that nothing has been altered apart from the checkpoint.

Considering that the content of the checkpoint is critical for security, this should be done internally within Parity.

@tomaka
Copy link
Contributor Author

tomaka commented Feb 10, 2022

After talking to Kirill, we could do the following:

  • Either merge Mark sync_state_genSyncSpec JSON-RPC as safe substrate#10832 or implement generating checkpoints in smoldot.
  • Have in this repo a GitHub Action that either grabs the checkpoint from a public JSON-RPC node, or generates a checkpoint by running smoldot, then opens a pull request.
  • Additionally, have another GitHub Action that, if a chain spec file is updated, checks whether smoldot can successfully connect to it and is on the same chain as a public JSON-RPC node.

@tomaka
Copy link
Contributor Author

tomaka commented Feb 16, 2022

paritytech/substrate#10832 being merged, we can wait for 0.9.18

@raoulmillais
Copy link
Contributor

Does this mean we can close this issue @tomaka ?

@tomaka
Copy link
Contributor Author

tomaka commented Apr 14, 2022

Almost

It just doesn't really work.

@raoulmillais
Copy link
Contributor

This is now working

@tomaka
Copy link
Contributor Author

tomaka commented Apr 19, 2022

Re-reading it, we also need this:

Additionally, have another GitHub Action that, if a chain spec file is updated, checks whether smoldot can successfully connect to it and is on the same chain as a public JSON-RPC node.

@tomaka tomaka reopened this Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants