Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrong assertion that unreleased crates returns status 200 #2

Open
niklasad1 opened this issue Nov 1, 2022 · 0 comments
Open

wrong assertion that unreleased crates returns status 200 #2

niklasad1 opened this issue Nov 1, 2022 · 0 comments

Comments

@niklasad1
Copy link
Member

"unrelased crates" doesn't return back status code 200

https://github.com/paritytech/subpub/blob/main/src/external/crates_io.rs#L32-#L33

When I tried sp-weights is not released on crates.io and it ended up with:

[2022-11-01T17:01:48Z ERROR subpub] Non-200 response code getting details for sp-weights

I provided a dummy solution for my but it could probably be ok to return an empty HashSet<Version> and continue with the rest of responses.
@jsdw jsdw self-assigned this Nov 3, 2022
@joao-paulo-parity joao-paulo-parity mentioned this issue Jan 9, 2023
Closed
@jsdw jsdw removed their assignment Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jsdw @niklasad1