update subxt #571
Merged
update subxt #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
commented
May 19, 2023
niklasad1
commented
May 24, 2023
niklasad1
commented
May 24, 2023
jsdw
approved these changes
Jun 1, 2023
lexnv
reviewed
Jun 1, 2023
| @@ -37,7 +37,7 @@ once_cell = "1.17" | |||
| [dev-dependencies] | |||
| anyhow = "1" | |||
| assert_cmd = "2.0" | |||
| sp-storage = "11.0.0" | |||
| sp-storage = { git = "https://github.com/paritytech/substrate" } | |||
There was a problem hiding this comment.
nit: Would the latest release 13.0.0 work here?
There was a problem hiding this comment.
yeah but I changed it because it doesn't make sense to make the dependency tree even bigger :)
There was a problem hiding this comment.
I need to release a bunch crates for that and my goal is to use master branches here and check out crates.io version on each release.
Because it's so annoying to patch crates if we need some specific from substrate that isn't released.
lexnv
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.