Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide artifacts upload tool as GHA #12

Closed
joao-paulo-parity opened this issue Nov 9, 2022 · 5 comments
Closed

Provide artifacts upload tool as GHA #12

joao-paulo-parity opened this issue Nov 9, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@joao-paulo-parity
Copy link
Contributor

As explained in https://github.com/paritytech/release-engineering/issues/102#issuecomment-1308414160

It should be rather trivial if the script is designed like we want the GHA to be. The idea behind using a GHA is also to shield us from the implementations details and whether we call the scripts direclty or use Docker for instance. All of those internal changes should not affect the repos using it.

Keep in mind that the "user" will be at the very least polkadot, substrate, cumulus and this list will grow. So instead of having each of those directly call the scripts (which would be possible indeed), I think the extra layer of the GHA could be benficial for the maintenance and the ease of use in the repos.

Since we intend to have multiple scripts in the repository, it's necessary to think about how to provide them as GitHub Actions. One approach would be to have multiple action.yml in a single repository for each entrypoint, as done by e.g. https://github.com/github/codeql-action/blob/73ff862014865b27593070d3b63161a0012a39ec/analyze/action.yml#L80 (see https://github.com/orgs/community/discussions/24990 and https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-using-a-public-action-in-a-subdirectory). Thus the usage would be:

- name: Use foo script
  uses: paritytech/releng-scripts/foo@master
  with:
    input: "bar"

- name: Use bar script
  uses: paritytech/releng-scripts/bar@master
@joao-paulo-parity joao-paulo-parity added the enhancement New feature or request label Nov 9, 2022
@chevdor
Copy link
Contributor

chevdor commented Nov 25, 2022

Since we have a public actions repo at https://github.com/paritytech/actions
The GHA will be reachable as: paritytech/actions/foo@master

@joao-paulo-parity
Copy link
Contributor Author

I thought of putting the actions in this repository (once it's made public, of course) because release-engineering owns it. I don't know who owns https://github.com/paritytech/actions. Do we have a strong preference for the actions repository over this one?

@chevdor
Copy link
Contributor

chevdor commented Nov 25, 2022

I think it would be good to have ALL GHA (not only about releases) in one repo and actions sounds rather good.
I requested admin rights in the repo.

@chevdor
Copy link
Contributor

chevdor commented Nov 25, 2022

See #17

@chevdor
Copy link
Contributor

chevdor commented Mar 2, 2023

We can follow up the topic here: paritytech/actions#2

@chevdor chevdor closed this as completed Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants