Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

fix migrations (also companion for #14421) #7454

Merged
merged 17 commits into from
Jul 13, 2023
Merged

fix migrations (also companion for #14421) #7454

merged 17 commits into from
Jul 13, 2023

Conversation

liamaharon
Copy link
Contributor

Partial paritytech/polkadot-sdk#481

Fixes polkadot*, kusama and rococo runtime upgrades.

also a companion for paritytech/substrate#14421

*polkadot will technically remain broken until https://polkadot.polkassembly.io/referenda/9 is enacted

@liamaharon liamaharon added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. E0-runtime_migration PR introduces code that might require downstream chains to run a runtime upgrade. T1-runtime This PR/Issue is related to the topic “runtime”. labels Jul 3, 2023
@paritytech-ci paritytech-ci requested review from a team July 3, 2023 15:09
This was referenced Aug 24, 2023
Closed
Merged
@paritytech-ci paritytech-ci requested review from a team July 4, 2023 12:39
bkchr
bkchr reviewed Jul 7, 2023
View reviewed changes
xcm/pallet-xcm/Cargo.toml Outdated Show resolved Hide resolved
xcm/pallet-xcm/src/migration.rs Show resolved Hide resolved
runtime/kusama/Cargo.toml Show resolved Hide resolved
@paritytech-ci paritytech-ci requested review from a team July 7, 2023 09:22
bkchr
bkchr approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as we are aware of the feature bleed, I'm okay with merging this as it is correct :)

The feature bleed is something that should probably fix itself with the removal of the native runtimes.

xcm/pallet-xcm/src/migration.rs Show resolved Hide resolved
@paritytech-ci paritytech-ci requested a review from a team July 10, 2023 14:54
@liamaharon liamaharon requested review from a team and chevdor as code owners July 11, 2023 02:39
@paritytech-ci paritytech-ci requested a review from a team July 11, 2023 02:39
@paritytech-processbot
Copy link

Merge cancelled due to error. Error: Head SHA changed from 61d56ab to 7ca4c57

@ggwpez
Copy link
Member

ggwpez commented Jul 13, 2023

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit 9361e82 into master Jul 13, 2023
@paritytech-processbot paritytech-processbot bot deleted the liam-fix-migrations branch July 13, 2023 10:39
@crystalin crystalin mentioned this pull request Oct 20, 2023
Closed
@JesseAbram JesseAbram mentioned this pull request Oct 26, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ggwpez ggwpez ggwpez left review comments

@bkchr bkchr bkchr approved these changes

@franciscoaguirre franciscoaguirre franciscoaguirre approved these changes

@ordian ordian ordian approved these changes

@KiChjang KiChjang KiChjang approved these changes

@kianenigma kianenigma Awaiting requested review from kianenigma

@chevdor chevdor Awaiting requested review from chevdor

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. E0-runtime_migration PR introduces code that might require downstream chains to run a runtime upgrade. T1-runtime This PR/Issue is related to the topic “runtime”.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@liamaharon @ggwpez @KiChjang @ordian @franciscoaguirre @kianenigma @bkchr