Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Add tests for PayOverXcm #7319

Merged
merged 15 commits into from
Aug 19, 2023
Merged

Add tests for PayOverXcm #7319

merged 15 commits into from
Aug 19, 2023

Conversation

franciscoaguirre
Copy link
Contributor

@franciscoaguirre franciscoaguirre commented May 31, 2023 •
edited
Loading

Adding tests for the new xcm-builder item, PayOverXcm, introduced in #6900.

TODO

  • Add all type parameters required to call pay on the test
  • Add test for native asset on destination chain
  • Add test for derivative asset on destination chain
  • Add test for salary pallet with PayOverXcm

@franciscoaguirre franciscoaguirre added A3-in_progress Pull request is in progress. No review needed at this stage. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. T6-XCM This PR/Issue is related to XCM. labels May 31, 2023
@franciscoaguirre
Copy link
Contributor Author

bot rebase

@paritytech-processbot
Copy link

Error: Command 'Command { std: cd "/storage/repositories/polkadot" && "git" "merge" "origin/master" "--no-ff" "--no-edit", kill_on_drop: false }' failed with status Some(1); output: no output

@franciscoaguirre franciscoaguirre force-pushed the cisco-pay-over-xcm-tests branch 2 times, most recently from 826f63c to 8867d33 Compare June 6, 2023 20:53
vstam1
vstam1 reviewed Jun 21, 2023
View reviewed changes
Copy link
Contributor

@vstam1 vstam1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me for as far as I understand the salary pallet.

Maybe add test for PayAccountId32OnChainOverXcm as well?

xcm/xcm-builder/src/tests/pay/salary.rs Show resolved Hide resolved
xcm/xcm-builder/src/tests/pay/salary.rs Outdated Show resolved Hide resolved
vstam1
vstam1 approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@vstam1 vstam1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@franciscoaguirre franciscoaguirre marked this pull request as ready for review July 26, 2023 14:30
@franciscoaguirre franciscoaguirre added A0-please_review Pull request needs code review. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. and removed A3-in_progress Pull request is in progress. No review needed at this stage. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Jul 26, 2023
@franciscoaguirre
Copy link
Contributor Author

bot rebase

@paritytech-processbot
Copy link

Branch is already up-to-date

@franciscoaguirre
Copy link
Contributor Author

bot rebase

@paritytech-processbot
Copy link

Branch is already up-to-date

@franciscoaguirre franciscoaguirre mentioned this pull request Jul 31, 2023
Open
@franciscoaguirre franciscoaguirre changed the title Add tests for PayOverXcm Add tests for PayOverXcm m Aug 8, 2023
@franciscoaguirre franciscoaguirre changed the title Add tests for PayOverXcm m Add tests for PayOverXcm Aug 8, 2023
@franciscoaguirre
Copy link
Contributor Author

bot rebase

@paritytech-processbot
Copy link

Rebased

@franciscoaguirre
Copy link
Contributor Author

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 47e58ac into master Aug 19, 2023
4 checks passed
@paritytech-processbot paritytech-processbot bot deleted the cisco-pay-over-xcm-tests branch August 19, 2023 13:39
@crystalin crystalin mentioned this pull request Oct 20, 2023
Closed
@JesseAbram JesseAbram mentioned this pull request Oct 26, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@liamaharon liamaharon liamaharon left review comments

@vstam1 vstam1 vstam1 approved these changes

@KiChjang KiChjang KiChjang approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. T6-XCM This PR/Issue is related to XCM.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@franciscoaguirre @KiChjang @vstam1 @liamaharon