This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Substrate Companion #7118
Merged
paritytech-processbot
merged 11 commits into
paritytech:master
from
Doordashcon:ddc-companion
May 11, 2023
Merged
Substrate Companion #7118
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
33d53cb
sudo benchmarks
Doordashcon 004dd2e
cargo fmt
Doordashcon be9c4fb
sub weights
Doordashcon ac69ac1
Update Cargo.lock
Doordashcon 3072cc7
NC.l
Doordashcon 4a3a13d
undo
Doordashcon 262f358
cargo fmt
Doordashcon 280d343
update sudo weights
Doordashcon c22e7f0
Merge branch 'paritytech:master' into ddc-companion
Doordashcon 1f45dd7
Merge remote-tracking branch 'origin/master' into ddc-companion
bbddf17
update lockfile for {"substrate"}
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,86 @@ | ||
// This file is part of Substrate. | ||
|
||
// Copyright (C) Parity Technologies (UK) Ltd. | ||
// SPDX-License-Identifier: Apache-2.0 | ||
|
||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
//! Autogenerated weights for pallet_sudo | ||
//! | ||
//! THIS FILE WAS AUTO-GENERATED USING THE SUBSTRATE BENCHMARK CLI VERSION 4.0.0-dev | ||
//! DATE: 2023-04-19, STEPS: `50`, REPEAT: `20`, LOW RANGE: `[]`, HIGH RANGE: `[]` | ||
//! WORST CASE MAP SIZE: `1000000` | ||
//! HOSTNAME: `bm3`, CPU: `Intel(R) Core(TM) i7-7700K CPU @ 4.20GHz` | ||
//! EXECUTION: Some(Wasm), WASM-EXECUTION: Compiled, CHAIN: Some("dev"), DB CACHE: 1024 | ||
|
||
// Executed Command: | ||
// target/production/substrate | ||
// benchmark | ||
// pallet | ||
// --steps=50 | ||
// --repeat=20 | ||
// --extrinsic=* | ||
// --execution=wasm | ||
// --wasm-execution=compiled | ||
// --heap-pages=4096 | ||
// --json-file=/var/lib/gitlab-runner/builds/zyw4fam_/0/parity/mirrors/substrate/.git/.artifacts/bench.json | ||
// --pallet=pallet_sudo | ||
// --chain=dev | ||
// --header=./HEADER-APACHE2 | ||
// --output=./frame/sudo/src/weights.rs | ||
// --template=./.maintain/frame-weight-template.hbs | ||
|
||
#![cfg_attr(rustfmt, rustfmt_skip)] | ||
#![allow(unused_parens)] | ||
#![allow(unused_imports)] | ||
|
||
use frame_support::{traits::Get, weights::Weight}; | ||
use core::marker::PhantomData; | ||
|
||
/// Weight functions for pallet_sudo. | ||
pub struct WeightInfo<T>(PhantomData<T>); | ||
impl<T: frame_system::Config> pallet_sudo::WeightInfo for WeightInfo<T> { | ||
/// Storage: Sudo Key (r:1 w:1) | ||
/// Proof: Sudo Key (max_values: Some(1), max_size: Some(32), added: 527, mode: MaxEncodedLen) | ||
fn set_key() -> Weight { | ||
// Proof Size summary in bytes: | ||
// Measured: `165` | ||
// Estimated: `1517` | ||
// Minimum execution time: 14_078_000 picoseconds. | ||
Weight::from_parts(14_405_000, 1517) | ||
.saturating_add(T::DbWeight::get().reads(1_u64)) | ||
.saturating_add(T::DbWeight::get().writes(1_u64)) | ||
} | ||
|
||
/// Storage: Sudo Key (r:1 w:0) | ||
/// Proof: Sudo Key (max_values: Some(1), max_size: Some(32), added: 527, mode: MaxEncodedLen) | ||
fn sudo() -> Weight { | ||
// Proof Size summary in bytes: | ||
// Measured: `165` | ||
// Estimated: `1517` | ||
// Minimum execution time: 14_009_000 picoseconds. | ||
Weight::from_parts(14_400_000, 1517) | ||
.saturating_add(T::DbWeight::get().reads(1_u64)) | ||
} | ||
|
||
/// Storage: Sudo Key (r:1 w:0) | ||
/// Proof: Sudo Key (max_values: Some(1), max_size: Some(32), added: 527, mode: MaxEncodedLen) | ||
fn sudo_as() -> Weight { | ||
// Proof Size summary in bytes: | ||
// Measured: `165` | ||
// Estimated: `1517` | ||
// Minimum execution time: 13_954_000 picoseconds. | ||
Weight::from_parts(14_248_000, 1517) | ||
.saturating_add(T::DbWeight::get().reads(1_u64)) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,86 @@ | ||
// This file is part of Substrate. | ||
|
||
// Copyright (C) Parity Technologies (UK) Ltd. | ||
// SPDX-License-Identifier: Apache-2.0 | ||
|
||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
//! Autogenerated weights for pallet_sudo | ||
//! | ||
//! THIS FILE WAS AUTO-GENERATED USING THE SUBSTRATE BENCHMARK CLI VERSION 4.0.0-dev | ||
//! DATE: 2023-04-19, STEPS: `50`, REPEAT: `20`, LOW RANGE: `[]`, HIGH RANGE: `[]` | ||
//! WORST CASE MAP SIZE: `1000000` | ||
//! HOSTNAME: `bm3`, CPU: `Intel(R) Core(TM) i7-7700K CPU @ 4.20GHz` | ||
//! EXECUTION: Some(Wasm), WASM-EXECUTION: Compiled, CHAIN: Some("dev"), DB CACHE: 1024 | ||
|
||
// Executed Command: | ||
// target/production/substrate | ||
// benchmark | ||
// pallet | ||
// --steps=50 | ||
// --repeat=20 | ||
// --extrinsic=* | ||
// --execution=wasm | ||
// --wasm-execution=compiled | ||
// --heap-pages=4096 | ||
// --json-file=/var/lib/gitlab-runner/builds/zyw4fam_/0/parity/mirrors/substrate/.git/.artifacts/bench.json | ||
// --pallet=pallet_sudo | ||
// --chain=dev | ||
// --header=./HEADER-APACHE2 | ||
// --output=./frame/sudo/src/weights.rs | ||
// --template=./.maintain/frame-weight-template.hbs | ||
|
||
#![cfg_attr(rustfmt, rustfmt_skip)] | ||
#![allow(unused_parens)] | ||
#![allow(unused_imports)] | ||
|
||
use frame_support::{traits::Get, weights::Weight}; | ||
use core::marker::PhantomData; | ||
|
||
/// Weight functions for pallet_sudo. | ||
pub struct WeightInfo<T>(PhantomData<T>); | ||
impl<T: frame_system::Config> pallet_sudo::WeightInfo for WeightInfo<T> { | ||
/// Storage: Sudo Key (r:1 w:1) | ||
/// Proof: Sudo Key (max_values: Some(1), max_size: Some(32), added: 527, mode: MaxEncodedLen) | ||
fn set_key() -> Weight { | ||
// Proof Size summary in bytes: | ||
// Measured: `165` | ||
// Estimated: `1517` | ||
// Minimum execution time: 14_078_000 picoseconds. | ||
Weight::from_parts(14_405_000, 1517) | ||
.saturating_add(T::DbWeight::get().reads(1_u64)) | ||
.saturating_add(T::DbWeight::get().writes(1_u64)) | ||
} | ||
|
||
/// Storage: Sudo Key (r:1 w:0) | ||
/// Proof: Sudo Key (max_values: Some(1), max_size: Some(32), added: 527, mode: MaxEncodedLen) | ||
fn sudo() -> Weight { | ||
// Proof Size summary in bytes: | ||
// Measured: `165` | ||
// Estimated: `1517` | ||
// Minimum execution time: 14_009_000 picoseconds. | ||
Weight::from_parts(14_400_000, 1517) | ||
.saturating_add(T::DbWeight::get().reads(1_u64)) | ||
} | ||
|
||
/// Storage: Sudo Key (r:1 w:0) | ||
/// Proof: Sudo Key (max_values: Some(1), max_size: Some(32), added: 527, mode: MaxEncodedLen) | ||
fn sudo_as() -> Weight { | ||
// Proof Size summary in bytes: | ||
// Measured: `165` | ||
// Estimated: `1517` | ||
// Minimum execution time: 13_954_000 picoseconds. | ||
Weight::from_parts(14_248_000, 1517) | ||
.saturating_add(T::DbWeight::get().reads(1_u64)) | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to run the benches, and use an actual weight for of runtimes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, can we call a bot to do that like is done on the Substrate repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, but I think it wont work until substrate is not merged
You can copy the weights from substrate. During the release process they will be replaced by actual weights.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, will do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done for Rococo/Westend. For the testing runtimes it does not matter.