This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
positive updates to reputations when good things happen #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
reviewed
May 9, 2019
rphmeier
reviewed
May 9, 2019
|
Also in the real |
rphmeier
reviewed
May 9, 2019
network/src/lib.rs
Outdated
| @@ -427,7 +428,7 @@ impl PolkadotProtocol { | |||
| ) { | |||
| match self.in_flight.remove(&(req_id, who.clone())) { | |||
| Some(mut req) => { | |||
| ctx.report_peer(who, cost::EXPECTED_MESSAGE); | |||
| ctx.report_peer(who, benefit::EXPECTED_MESSAGE); | |||
There was a problem hiding this comment.
This is not necessarily a good response -- I think we should branch:
- if
pov_blockisNone, a small bump to reputation - if
pov_blockisSomeand is good, a big bump to reputation - if
pov_blockisSomeand is bad, a big hit to reputation.
rphmeier
approved these changes
May 15, 2019
tomusdrw
pushed a commit
that referenced
this pull request
Mar 26, 2021
* replace debug printlns with traces * cargo fmt --all * fixed traces * update RUST_LOG in docker-compose * only print hex data if error has occured * updated OE hash
imstar15
pushed a commit
to imstar15/polkadot
that referenced
this pull request
Aug 25, 2021
* HRMP message ingestion * Plumb hrmp_watermark to build_collation * Plumb hrmp_watermark to ValidationResult * Plumb hrmp outbound messages * Implement message-broker part of HRMP * Kill UPWARD_MESSAGES as well Otherwise, they will get resent each block * Add sudo versions for easier testing * Remove the xcmp module Not useful for the moment * Doc for HRMP message handler * Estimate the weight upper bound for on_finalize * Remove a redundant type annotation * fix spelling of a method * Apply suggestions from code review Co-authored-by: Bastian Köcher <[email protected]> * Deabbreviate dmp and hrmp in the message ingestion type * Don't use binary_search since it's broken by a following rotate Instead use the linear search. We can afford linear search here since due to limited scalability of HRMP we can only have at most a couple of dozens of channels. * Fix the watermark Co-authored-by: Bastian Köcher <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #251
I've assigned some constants with the intuition that bad things should matter more than symmetrical good things (10x), but probably that should change.