Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Use larger channel sizes for approval-distribution #6614

Closed
sandreim opened this issue Jan 23, 2023 · 0 comments · Fixed by #6905
Closed

Use larger channel sizes for approval-distribution #6614

sandreim opened this issue Jan 23, 2023 · 0 comments · Fixed by #6905
Assignees
Labels
T4-parachains_engineering This PR/Issue is related to Parachains performance, stability, maintenance. U1-asap No need to stop dead in your tracks, however issue should be addressed as soon as possible.

Comments

@sandreim
Copy link
Contributor

This would be just an easy workaround until paritytech/polkadot-sdk#810 is implemented.

We want to quickly address the current limitations of the network RX bridge by not blocking when processing network messages if the approval-distribution channel gets full. This results in peer view updates propagation lagging behind the actual work and timeouts of bitfield signing and provisioner.

I've experimented on Versi (300 para validators and 60 parachains) with channels as large as 32k and got very good results (except that spike).

Screenshot 2023-01-23 at 15 12 10

Depends on paritytech/orchestra#24 to be implemented.

@sandreim sandreim added U1-asap No need to stop dead in your tracks, however issue should be addressed as soon as possible. T4-parachains_engineering This PR/Issue is related to Parachains performance, stability, maintenance. labels Jan 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T4-parachains_engineering This PR/Issue is related to Parachains performance, stability, maintenance. U1-asap No need to stop dead in your tracks, however issue should be addressed as soon as possible.
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants