Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Typesafe MultiAsset Wildcards #3168

Closed
gavofyork opened this issue Jun 3, 2021 · 2 comments
Closed

Typesafe MultiAsset Wildcards #3168

gavofyork opened this issue Jun 3, 2021 · 2 comments
Labels
T6-XCM This PR/Issue is related to XCM.

Comments

@gavofyork
Copy link
Member

Right now, wildcard MultiAsset values (which are entirely indefinite and dependent on some context) are expressed by the same type as definite MultiAsset values. This leads to issues where items are accidentally not handled since indefinite wildcard values are unresolved at the time of handling and erroneously ignored.

To combat this, there should a new type WildMultiAsset which alone can express indefinite wildcard values. This is what would be typically used in XCM, but most internal functions would continue to operate on MultiAsset values (which will be altered so that it can only express definite assets). A WildMultiAsset::resolve function would convert one to the other, given a context, which would typically be the holding account.

This would probably be best combined with the move to the new MultiAsset (#2815).

@apopiak
Copy link
Contributor

apopiak commented Aug 16, 2021

Is this fully addressed by #2815 ?

@KiChjang KiChjang added the T6-XCM This PR/Issue is related to XCM. label Dec 28, 2021
@KiChjang
Copy link
Contributor

I believe this is fully resolved as of XCM v3.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T6-XCM This PR/Issue is related to XCM.
Projects
None yet
Development

No branches or pull requests

3 participants