Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Integrate all subsystems with the Overseer #1317

Closed
rphmeier opened this issue Jun 25, 2020 · 0 comments · Fixed by #1374
Closed

Integrate all subsystems with the Overseer #1317

rphmeier opened this issue Jun 25, 2020 · 0 comments · Fixed by #1374
Assignees
Labels
S1-implement PR/Issue is in the implementation stage
Milestone

Comments

@rphmeier
Copy link
Contributor

This can speculatively be done before the subsystems are actually implemented.

However, I'd recommend introducing a helper DummySubsystem first, which implements Subsystem for all message types, creating a future that spins forever. Then users of the Overseer can just supply DummySubsystem to those subsystems that it doesn't need to do anything for. This will make test setup dramatically easier.

@rphmeier rphmeier added Q2-easy S1-implement PR/Issue is in the implementation stage labels Jun 25, 2020
@rphmeier rphmeier added this to the Rockville milestone Jun 25, 2020
@ordian ordian self-assigned this Jul 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
S1-implement PR/Issue is in the implementation stage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants