Coretime Sale ID #6626
Coretime Sale ID #6626
Conversation
|
User @FereMouSiopi, please sign the CLA here. |
| @@ -105,7 +105,15 @@ impl<T: Config> Pallet<T> { | |||
| cores_offered: 0, | |||
| cores_sold: 0, | |||
There was a problem hiding this comment.
Maybe we could just add the sale_id to the SaleInfoRecord?
Also we will need a migration that sets sale_id to the correct value.
There was a problem hiding this comment.
We would not need to include sale_index in the event emitted when sale starts, instead when SaleInitialized?
Runtime devs and users should query the SaleInfo for the current sale Id?
There was a problem hiding this comment.
Is there a way to know how many sales have elapsed since? this is for migration purposes.
There was a problem hiding this comment.
The migration would need to require to know when the first sale happened and then it can calculate the current sale number
There was a problem hiding this comment.
On Kusama that might be fiddly because we re-started sales (we have a "sale" which is one week long) - raises the question: do we count that as sale 0 or just ignore it as the symptom of a bug? Would be interesting to see how others have labelled it. I guess you could just have an input sales_at_block along with the start block and current block or whatever. I'm sure you could simplify that too, but that's the fully general one for which the upgrade wouldn't need to be timed.
There was a problem hiding this comment.
do we count that as sale 0 or just ignore it as the symptom of a bug?
We just ignore. By restarting we have voided any sales etc any way? (don't remember the exact details)
substrate/frame/broker/src/lib.rs
Outdated
| @@ -346,6 +350,8 @@ pub mod pallet { | |||
| price: BalanceOf<T>, | |||
| /// The maximum number of cores which this pallet will attempt to assign. | |||
| core_count: CoreIndex, | |||
| /// Identifier for the current sale. | |||
| sale_id: u32, | |||
There was a problem hiding this comment.
sale_index might be a better name for this (and throughout the PR)
prdoc/pr_6626.prdoc
Outdated
|
|
||
| crates: | ||
| - name: pallet-broker | ||
| bump: minor |
There was a problem hiding this comment.
| bump: minor | |
| bump: major |
Adding a new field to an enum variant is a breaking change
prdoc/pr_6626.prdoc
Outdated
| title: coretime sale id | ||
|
|
||
| doc: | ||
| - audience: Runtime Dev |
There was a problem hiding this comment.
Also relevant for Runtime Users
Resolves #6354