-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
polkadot-sdk-docs: Use command_macro! #6624
Conversation
Can you please use |
@iulianbarbu, I used a slightly modified version of the macro used in |
docs/sdk/src/reference_docs/chain_spec_runtime/tests/chain_spec_builder_tests.rs
Outdated
Show resolved
Hide resolved
docs/sdk/src/reference_docs/chain_spec_runtime/tests/chain_spec_builder_tests.rs
Outdated
Show resolved
Hide resolved
Bot fmt and label needed 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ndkazu , one small remark related to the PRDOC.
docs/sdk/src/reference_docs/chain_spec_runtime/tests/chain_spec_builder_tests.rs
Outdated
Show resolved
Hide resolved
@iulianbarbu it's done: Thank you for the mentoring during this PR⇒ I learned a lot!!!! |
It would be nice to review/merge this PR and close the corresponding issue: @michalkucharczyk , we need your help 🙏 !! |
Is this still a problem? If not, would you please update description? |
Should be fixed by: |
Description updated! |
19bc578
/tip small |
The referendum has appeared on Polkassembly. |
# Description **Understood assignment:** Initial assignment description is in #6194. In order to Simplify the display of commands and ensure they are tested for chain spec builder's `polkadot-sdk` reference docs, find every occurrence of `#[docify::export]` where `process:Command` is used, and replace the use of `process:Command` by `run_cmd!` from the `cmd_lib crate`. --------- Co-authored-by: Iulian Barbu <[email protected]>
Description
Understood assignment:
Initial assignment description is in #6194.
In order to Simplify the display of commands and ensure they are tested for chain spec builder's
polkadot-sdk
reference docs, find every occurrence of#[docify::export]
whereprocess:Command
is used, and replace the use ofprocess:Command
byrun_cmd!
from thecmd_lib crate
.