Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport] Add benchmark for the number of minimum cpu cores (#5127) #5613

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

alexggh
Copy link
Contributor

@alexggh alexggh commented Sep 6, 2024

This backports #5127, to the stable branch.

Unfortunately https://polkadot.subsquare.io/referenda/1051 passed after the cut-off deadline and I missed the window of getting this PR merged.

The change itself is super low-risk it just prints a new message to validators that starting with January 2025 the required minimum of hardware cores will be 8, I see value in getting this in front of the validators as soon as possible.

Since we did not release things yet and it does not invalidate any QA we already did, it should be painless to include it in the current release.

(cherry picked from commit a947cb8)

@alexggh alexggh requested a review from koute as a code owner September 6, 2024 08:02
@alexggh alexggh requested review from ggwpez and EgorPopelyaev and removed request for koute September 6, 2024 08:02
@alexggh alexggh added the R0-silent Changes should not be mentioned in any release notes label Sep 6, 2024
Copy link

github-actions bot commented Sep 6, 2024

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree that this is very low-risk since it modifies a single console command and should not restart QA testing.

@ggwpez ggwpez merged commit 823ecee into stable2409 Sep 9, 2024
216 of 221 checks passed
@ggwpez ggwpez deleted the alexggh/stable2409 branch September 9, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants