fixed GrandpaConsensusLogReader::find_scheduled_change #4209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkontur
approved these changes
Apr 19, 2024
|
lock file needed update: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5990572 - apparently left from some previous PR |
|
The CI pipeline was cancelled due to failure one of the required jobs. |
|
I guess now it fails because CI image has been updated? I can prepare a separate PR for backporting #4077 or can we just ignore CI here? Never knew how our release branches work with that :/ |
acatangiu
approved these changes
Apr 19, 2024
Morgan will do it manually: bump version + publish to crates.io |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'll need to prepare a hotfix
1.2.2release for fellowship runtimesWe need to republish
bp-header-chainwith minor version bump. Should I do it here manually or it happens automatically? @Morganamilo