[testnet] Align testnet system parachain runtimes using `RelayTreasuryLocation` and `SystemParachains` in the same way #2023

bkontur · 2023-10-25T08:49:01Z

This PR addresses several issues:

simplify referencing RelayTreasuryLocation without needing additional RelayTreasury struct
fix for referencing SystemParachains from parachain with parents: 1 instead of parents: 0
removed hard-coded constants and fix tests for asset-hub-rococo which was merged to master after [xcm] Use Weight::MAX for reserve_asset_deposited, receive_teleported_asset benchmarks #1726

… the same way.

bkontur · 2023-10-25T08:50:12Z

bot bench cumulus-assets --runtime asset-hub-rococo --subcommand xcm --pallet pallet_xcm_benchmarks::fungible

…set-hub-rococo --runtime_dir=assets --target_dir=cumulus --pallet=pallet_xcm_benchmarks::fungible

bkontur · 2023-10-25T11:39:03Z

bot bench cumulus-assets --runtime asset-hub-rococo --subcommand xcm --pallet pallet_xcm_benchmarks::fungible

…nto HEAD

…set-hub-rococo --runtime_dir=assets --target_dir=cumulus --pallet=pallet_xcm_benchmarks::fungible

bkontur · 2023-10-25T13:12:32Z

bot clean

bkontur · 2023-10-25T13:17:37Z

bot fmt

command-bot · 2023-10-25T13:17:41Z

@bkontur https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4080316 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 8-d23b1874-5300-4be8-9a1c-36aca4745281 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2023-10-25T13:22:00Z

@bkontur Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4080316 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4080316/artifacts/download.

paritytech-cicd-pr · 2023-10-25T13:48:47Z

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 3/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4080594

franciscoaguirre · 2023-10-25T15:33:16Z

...arachains/runtimes/assets/asset-hub-rococo/src/weights/xcm/pallet_xcm_benchmarks_fungible.rs

 	// Proof: `System::Account` (`max_values`: None, `max_size`: Some(128), added: 2603, mode: `MaxEncodedLen`)
+	// Storage: UNKNOWN KEY `0x48297505634037ef48c848c99c0b1f1b` (r:1 w:0)


What's up with these unknown keys?

* master: Removed TODO from test-case for hard-coded delivery fee estimation (#2042) Expose collection attributes from `Inspect` trait (#1914) `polkadot-parachain-primitives` should not depend on `frame-support`. (#1897) [testnet] Align testnet system parachain runtimes using `RelayTreasuryLocation` and `SystemParachains` in the same way (#2023) Sort the benchmarks before listing them (#2026) publish pallet-root-testing (#2017) Contracts: Add benchmarks to include files (#2022) Small optimisation to `--profile dev` wasm builds (#1851) basic-authorship: Improve time recording and logging (#2010) Application Crypto and BEEFY Support for paired (ECDSA,BLS) crypto (#1815) [ci] Run check-rust-feature-propagation in pr and master (#2012) Improve features dev-ex (#1831) Remove obsolete comment. (#2008)

* tsv-disabling: Removed TODO from test-case for hard-coded delivery fee estimation (#2042) Expose collection attributes from `Inspect` trait (#1914) `polkadot-parachain-primitives` should not depend on `frame-support`. (#1897) [testnet] Align testnet system parachain runtimes using `RelayTreasuryLocation` and `SystemParachains` in the same way (#2023) Sort the benchmarks before listing them (#2026) publish pallet-root-testing (#2017) Contracts: Add benchmarks to include files (#2022) Small optimisation to `--profile dev` wasm builds (#1851) basic-authorship: Improve time recording and logging (#2010) Application Crypto and BEEFY Support for paired (ECDSA,BLS) crypto (#1815) [ci] Run check-rust-feature-propagation in pr and master (#2012) Improve features dev-ex (#1831) Remove obsolete comment. (#2008)

* tsv-disabling: (36 commits) Removed TODO from test-case for hard-coded delivery fee estimation (#2042) Expose collection attributes from `Inspect` trait (#1914) `polkadot-parachain-primitives` should not depend on `frame-support`. (#1897) [testnet] Align testnet system parachain runtimes using `RelayTreasuryLocation` and `SystemParachains` in the same way (#2023) Sort the benchmarks before listing them (#2026) publish pallet-root-testing (#2017) Contracts: Add benchmarks to include files (#2022) Small optimisation to `--profile dev` wasm builds (#1851) basic-authorship: Improve time recording and logging (#2010) Application Crypto and BEEFY Support for paired (ECDSA,BLS) crypto (#1815) [ci] Run check-rust-feature-propagation in pr and master (#2012) Improve features dev-ex (#1831) Remove obsolete comment. (#2008) Refactor candidates test in paras_inherent (#2004) PVF: Add worker check during tests and benches (#1771) Bump actions/setup-node from 3.8.1 to 4.0.0 (#1997) polkadot: enable tikv-jemallocator/unprefixed_malloc_on_supported_platforms (#2002) Make `IdentityInfo` generic in `pallet-identity` (#1661) Ensure correct variant count in `Runtime[Hold/Freeze]Reason` (#1900) `CheckWeight`: Add more logging (#1996) ...

…yLocation` and `SystemParachains` in the same way (#2023) This PR addresses several issues: - simplify referencing `RelayTreasuryLocation` without needing additional `RelayTreasury` struct - fix for referencing `SystemParachains` from parachain with `parents: 1` instead of `parents: 0` - removed hard-coded constants and fix tests for `asset-hub-rococo` which was merged to master after #1726 --------- Co-authored-by: command-bot <>

This PR backports missing PR's needed for 1.3.0 cumulus release: #2042 #2139 #2129 #1967 #2021 #1887 #2023 --------- Co-authored-by: Branislav Kontur <[email protected]> Co-authored-by: Lulu <[email protected]> Co-authored-by: Sergejs Kostjucenko <[email protected]> Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: Serban Iorga <[email protected]> Co-authored-by: Adrian Catangiu <[email protected]> Co-authored-by: joe petrowski <[email protected]> Co-authored-by: Svyatoslav Nikolsky <[email protected]>

* reject delivery transactions with at least one obsolete message * clippy * boost priority of message delivery transactions: transaction with more messages has larger priority than the transaction with less messages * apply review suggestion * CallInfo::bundled_messages * validate_does_not_boost_priority_of_message_delivery_transactons_with_too_many_messages * clippy

Align testnet system parachain runtimes using RelayTreasuryLocation…

2d88d83

… the same way.

bkontur added the T9-cumulus This PR/Issue is related to cumulus. label Oct 25, 2023

command-bot and others added 2 commits October 25, 2023 09:58

".git/.scripts/commands/bench/bench.sh" --subcommand=xcm --runtime=as…

515e02b

…set-hub-rococo --runtime_dir=assets --target_dir=cumulus --pallet=pallet_xcm_benchmarks::fungible

Setup TrustedReserve on asset-hub-rococo

b4b5361

command-bot and others added 3 commits October 25, 2023 11:41

Merge branch 'master' of https://github.com/paritytech/polkadot-sdk i…

fca14bb

…nto HEAD

".git/.scripts/commands/bench/bench.sh" --subcommand=xcm --runtime=as…

8a8d218

…set-hub-rococo --runtime_dir=assets --target_dir=cumulus --pallet=pallet_xcm_benchmarks::fungible

Adjusted test weights

c7d9949

bkontur marked this pull request as ready for review October 25, 2023 13:12

".git/.scripts/commands/fmt/fmt.sh"

1920fa3

acatangiu approved these changes Oct 25, 2023

View reviewed changes

bkontur enabled auto-merge (squash) October 25, 2023 13:30

bkontur added 2 commits October 25, 2023 16:49

Adjusted test weights + moved assert before checking balances

1297cfd

Merge remote-tracking branch 'origin/master' into bko-testnet-nits

7c6c1e5

franciscoaguirre approved these changes Oct 25, 2023

View reviewed changes

bkontur merged commit f6560c2 into master Oct 25, 2023
93 of 110 checks passed

bkontur deleted the bko-testnet-nits branch October 25, 2023 15:35

EgorPopelyaev mentioned this pull request Nov 6, 2023

Backport missing functionalities for cumulus #2176

Merged

bkontur mentioned this pull request Nov 10, 2023

Upgrade dependencies svyatonik/runtimes#2

Closed

github-actions bot mentioned this pull request Feb 19, 2024

Update substrate/polkadot/cumulus from v1.3.0 to v1.6.0 moondance-labs/tanssi#419

Closed

github-actions bot mentioned this pull request Mar 13, 2024

Update polkadot-sdk from v1.3.0 to v1.7.2 moonbeam-foundation/moonbeam#2703

Closed

This was referenced Jun 5, 2024

Update polkadot-sdk from v1.7.0 to v1.11.0 moondance-labs/tanssi#573

Closed

Update polkadot-sdk from v1.10.0 to v1.11.0 moondance-labs/tanssi#577

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[testnet] Align testnet system parachain runtimes using `RelayTreasuryLocation` and `SystemParachains` in the same way #2023

[testnet] Align testnet system parachain runtimes using `RelayTreasuryLocation` and `SystemParachains` in the same way #2023

bkontur commented Oct 25, 2023 •

edited

Loading

bkontur commented Oct 25, 2023

bkontur commented Oct 25, 2023

bkontur commented Oct 25, 2023

bkontur commented Oct 25, 2023

command-bot bot commented Oct 25, 2023 •

edited

Loading

command-bot bot commented Oct 25, 2023

paritytech-cicd-pr commented Oct 25, 2023

franciscoaguirre Oct 25, 2023

		// Proof: `System::Account` (`max_values`: None, `max_size`: Some(128), added: 2603, mode: `MaxEncodedLen`)
		// Storage: UNKNOWN KEY `0x48297505634037ef48c848c99c0b1f1b` (r:1 w:0)

[testnet] Align testnet system parachain runtimes using RelayTreasuryLocation and SystemParachains in the same way #2023

[testnet] Align testnet system parachain runtimes using RelayTreasuryLocation and SystemParachains in the same way #2023

Conversation

bkontur commented Oct 25, 2023 • edited Loading

bkontur commented Oct 25, 2023

bkontur commented Oct 25, 2023

bkontur commented Oct 25, 2023

bkontur commented Oct 25, 2023

command-bot bot commented Oct 25, 2023 • edited Loading

command-bot bot commented Oct 25, 2023

paritytech-cicd-pr commented Oct 25, 2023

franciscoaguirre Oct 25, 2023

Choose a reason for hiding this comment

[testnet] Align testnet system parachain runtimes using `RelayTreasuryLocation` and `SystemParachains` in the same way #2023

[testnet] Align testnet system parachain runtimes using `RelayTreasuryLocation` and `SystemParachains` in the same way #2023

bkontur commented Oct 25, 2023 •

edited

Loading

command-bot bot commented Oct 25, 2023 •

edited

Loading