Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nit: use traits::tokens::fungible => use traits::fungible #1753

Merged
merged 7 commits into from
Oct 17, 2023
Merged

nit: use traits::tokens::fungible => use traits::fungible #1753

merged 7 commits into from
Oct 17, 2023

Conversation

gilescope
Copy link
Contributor

Slightly less verbose use of fungible(s).

@gilescope gilescope added the T2-pallets This PR/Issue is related to a particular pallet. label Sep 29, 2023
@gilescope gilescope marked this pull request as ready for review September 29, 2023 11:24
@gilescope gilescope requested review from a team September 29, 2023 11:24
@gilescope gilescope requested a review from a team as a code owner September 29, 2023 11:24
liamaharon
liamaharon approved these changes Sep 29, 2023
View reviewed changes
polkadot/xcm/xcm-builder/src/asset_conversion.rs Outdated Show resolved Hide resolved
polkadot/xcm/xcm-builder/src/fungibles_adapter.rs Outdated Show resolved Hide resolved
polkadot/xcm/xcm-builder/src/nonfungibles_adapter.rs Outdated Show resolved Hide resolved
@ggwpez ggwpez enabled auto-merge (squash) October 17, 2023 09:29
@ggwpez ggwpez merged commit d9e266f into master Oct 17, 2023
89 of 111 checks passed
@ggwpez ggwpez deleted the giles-nit-fungible-namespace branch October 17, 2023 09:56
tdimitrov pushed a commit that referenced this pull request Oct 23, 2023
@gilescope @liamaharon @tdimitrov
nit: use traits::tokens::fungible => use traits::fungible (#1753)
341423e 
Slightly less verbose use of fungible(s).

---------

Co-authored-by: Liam Aharon <[email protected]>
@kiltbot kiltbot mentioned this pull request Nov 7, 2023
Closed
@ahmadkaouk ahmadkaouk mentioned this pull request Nov 16, 2023
Closed
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
@gilescope @liamaharon
nit: use traits::tokens::fungible => use traits::fungible (paritytech…
4934751 
…#1753)

Slightly less verbose use of fungible(s).

---------

Co-authored-by: Liam Aharon <[email protected]>
serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Mar 26, 2024
@serban300
Use indirect runtime calls for RialtoParachain (paritytech#1753)
13f4a01 
* Use indirect runtime calls for RialtoParachain

* Code review fixes
serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Mar 27, 2024
@serban300
Use indirect runtime calls for RialtoParachain (paritytech#1753)
3d4477a 
* Use indirect runtime calls for RialtoParachain

* Code review fixes
serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@serban300
Use indirect runtime calls for RialtoParachain (paritytech#1753)
e806762 
* Use indirect runtime calls for RialtoParachain

* Code review fixes
serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@serban300
Use indirect runtime calls for RialtoParachain (paritytech#1753)
0697ea0 
* Use indirect runtime calls for RialtoParachain

* Code review fixes
serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@serban300
Use indirect runtime calls for RialtoParachain (paritytech#1753)
80ad4f9 
* Use indirect runtime calls for RialtoParachain

* Code review fixes
serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@serban300
Use indirect runtime calls for RialtoParachain (paritytech#1753)
ad191a2 
* Use indirect runtime calls for RialtoParachain

* Code review fixes
serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@serban300
Use indirect runtime calls for RialtoParachain (paritytech#1753)
e5e62c8 
* Use indirect runtime calls for RialtoParachain

* Code review fixes
serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@serban300
Use indirect runtime calls for RialtoParachain (paritytech#1753)
7a55c54 
* Use indirect runtime calls for RialtoParachain

* Code review fixes
serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@serban300
Use indirect runtime calls for RialtoParachain (paritytech#1753)
2c66c1b 
* Use indirect runtime calls for RialtoParachain

* Code review fixes
serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@serban300
Use indirect runtime calls for RialtoParachain (paritytech#1753)
d58ad6c 
* Use indirect runtime calls for RialtoParachain

* Code review fixes
serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@serban300
Use indirect runtime calls for RialtoParachain (paritytech#1753)
b2078a5 
* Use indirect runtime calls for RialtoParachain

* Code review fixes
serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@serban300
Use indirect runtime calls for RialtoParachain (paritytech#1753)
3a1cc03 
* Use indirect runtime calls for RialtoParachain

* Code review fixes
serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@serban300
Use indirect runtime calls for RialtoParachain (paritytech#1753)
7ba43c5 
* Use indirect runtime calls for RialtoParachain

* Code review fixes
serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 10, 2024
@serban300
Use indirect runtime calls for RialtoParachain (paritytech#1753)
bb79428 
* Use indirect runtime calls for RialtoParachain

* Code review fixes
serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 10, 2024
@serban300
Use indirect runtime calls for RialtoParachain (paritytech#1753)
3bfd8d2 
* Use indirect runtime calls for RialtoParachain

* Code review fixes
bkchr pushed a commit that referenced this pull request Apr 10, 2024
@serban300 @bkchr
Use indirect runtime calls for RialtoParachain (#1753)
444dbe7 
* Use indirect runtime calls for RialtoParachain

* Code review fixes
This was referenced Jun 5, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamaharon liamaharon liamaharon approved these changes

@ggwpez ggwpez ggwpez approved these changes

@KiChjang KiChjang KiChjang approved these changes

Assignees
No one assigned
Labels
T2-pallets This PR/Issue is related to a particular pallet.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gilescope @KiChjang @ggwpez @liamaharon