-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check all benchmark results #6722
Comments
This is more than just running the benchmarks. We did a lot of changes to the pallet without paying much attention to the benchmarks. I need to go through them and make sure they make sense. Some of them need to be reworked like #6157 |
Thats okay. Just re-running the benchmarks should not break anything. Production chains will have their own benchmarks anyways. |
#5792 related issues about generally having correct weights across the board. Parachains should generally have "correct" weights at all times. |
Before releasing on any value bearing chain we need to make sure that all benchmark results and hence weights do make sense.
The text was updated successfully, but these errors were encountered: