Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polkadot --version check for execute and prepare binary #6671

Closed
ggwpez opened this issue Nov 27, 2024 · 1 comment
Closed

polkadot --version check for execute and prepare binary #6671

ggwpez opened this issue Nov 27, 2024 · 1 comment
Labels
I10-unconfirmed Issue might be valid, but it's not yet known.

Comments

@ggwpez
Copy link
Member

ggwpez commented Nov 27, 2024

This is more of Q and suggestion: maybe the version output of the polkadot binary should also do a light self-check to ensure that the execute and prepare worker binaries exist and have the expected version.

Someone in the validator lounge posted this which got me thinking:

I m now concerned about the installation (polkadot-execute-worker and polkadot-prepare-worker returns command not found whereas polkadot --version returns polkadot 1.16.2-dba2dd59101) ...

@ggwpez ggwpez added the I10-unconfirmed Issue might be valid, but it's not yet known. label Nov 27, 2024
@ggwpez ggwpez changed the title polkadot --version could check for execute and prepare binary polkadot --version check for execute and prepare binary Nov 27, 2024
@bkchr
Copy link
Member

bkchr commented Dec 24, 2024

These version checks are done at startup of the node. It checks if the workers exist and if they have the correct version. So, I don't see a reason that we do this check as part of version. Maybe it could be its own check check-installation, but I don't see that much value in this if the node refuses to work if it can not find the workers any way. The node also provides the option to pass the paths of the workers manually, which would bring up the question, should the extra check do this as well, but then people may forget to pass these paths to the node launch etc.

TLDR: I think this is not actionable/required right now.

@bkchr bkchr closed this as completed Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I10-unconfirmed Issue might be valid, but it's not yet known.
Projects
Status: No status
Development

No branches or pull requests

2 participants