Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the era inflation distribution from the staking pallet. #6158

Open
3 tasks
gpestana opened this issue Oct 21, 2024 · 0 comments
Open
3 tasks

Deprecate the era inflation distribution from the staking pallet. #6158

gpestana opened this issue Oct 21, 2024 · 0 comments
Assignees
Labels
T2-pallets This PR/Issue is related to a particular pallet.

Comments

@gpestana
Copy link
Contributor

gpestana commented Oct 21, 2024

The #5999 somewhat overlaps with the MaxStakedRewards and the era payout distribution that happens at the staking level.

In Westend the staking pallet will make sure that the era validator payout is max MaxStakedRewards is enforced . Since the EraPayout implementation in Westend is returning a 15% to treasury and 85% to stakers, the staking pallet will adjust the staker payout to 80% and remainder value to 20% (effectively overwritting the values returned by EraPayout impl).

It is cleaner to perform the treasury/stakers era inflation distribution in the implementation of the EraPayout, instead of doing it at the staking pallet level (I'd go further and make the & parameterizable with the params pallet, which does not seems to be the case atm).

By moving the era inflation to the EraPayout implementation, we can remove the distribution (MaxStakedRewards, etc) logic from the staking pallet.

Note: ensure that both Kusama and Polkadot runtimes have the EraPayout implementation up to date with the era payout distribution before rolling out these changes in the staking pallet.

Note 2.: MaxStakedRewards in Kusama and Polkadot is set to None, thus the over-writing of the inflation distribution is disabled.

Tasks

Preview Give feedback
@gpestana gpestana added the T2-pallets This PR/Issue is related to a particular pallet. label Oct 21, 2024
@gpestana gpestana self-assigned this Oct 21, 2024
@gpestana gpestana moved this from 📕 Backlog to ⌛️ Sometime-soon in (Nominated) Proof of Stake Oct 21, 2024
@gpestana gpestana moved this from ⌛️ Sometime-soon to ✂️ In progress. in (Nominated) Proof of Stake Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T2-pallets This PR/Issue is related to a particular pallet.
Projects
Status: ✂️ In progress.
Development

No branches or pull requests

1 participant