Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

approval-distribution: don't fan-out multiple assignments/approvals in separate notifications #615

Closed
sandreim opened this issue Jun 14, 2023 · 1 comment
Assignees
Labels
I9-optimisation An enhancement to provide better overall performance in terms of time-to-completion for a task.

Comments

@sandreim
Copy link
Contributor

Continued from #732

One idea I have is to have the import_and_circulate_assignment and import_and_circulate_approval functions return the approval/assignment wrapped in an Option. Filtering and everything else should work the same as now. We accumulate these in https://github.com/paritytech/polkadot/blob/master/node/network/approval-distribution/src/lib.rs#L568 and send to peers (this assumes the routing information was updated and is the same for all messages) as a last step.

@alexggh alexggh self-assigned this Jun 14, 2023
@Sophia-Gold Sophia-Gold transferred this issue from paritytech/polkadot Aug 24, 2023
@the-right-joyce the-right-joyce added I9-optimisation An enhancement to provide better overall performance in terms of time-to-completion for a task. T8-parachains_engineering and removed I10-optimisation labels Aug 25, 2023
@alexggh
Copy link
Contributor

alexggh commented Aug 28, 2024

Not needed anymore superseded by: #4849

@alexggh alexggh closed this as completed Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I9-optimisation An enhancement to provide better overall performance in terms of time-to-completion for a task.
Projects
Status: Completed
Development

No branches or pull requests

3 participants