Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parchains scheduler: ttl value is off #4695

Closed
5 tasks
eskimor opened this issue Jun 4, 2024 · 1 comment
Closed
5 tasks

Parchains scheduler: ttl value is off #4695

eskimor opened this issue Jun 4, 2024 · 1 comment

Comments

@eskimor
Copy link
Member

eskimor commented Jun 4, 2024

This check is nice, but in reality ttl should never be larger either as it then would allow one parachain to starve the other in a core sharing scenario.

We should just derive ttl from the lookahead directly and deprecate the ttl configuration.

The idea here was that collations can be backed out of order, but we don't actually do that and also agreed that it is a bad idea, with very little gain, but added complexity.

  • Deprecate/remove ttl configuration value
  • Ignore its value and instead make it always equal claim queue length
  • Fix this check to <=.
  • Test that backing in a core sharing fashion works, even if one para does not provide collations.
  • Test that classic synchronous backing (12s block times) continues to work.
@eskimor eskimor converted this from a draft issue Jun 4, 2024
@sandreim
Copy link
Contributor

Closing in favor of #4776 which removes the TTL completely.

@github-project-automation github-project-automation bot moved this from Backlog to Completed in parachains team board Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Completed
Development

No branches or pull requests

2 participants