Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network: Enable tests of Notifications #4692

Closed
dmitry-markin opened this issue Jun 4, 2024 · 1 comment
Closed

network: Enable tests of Notifications #4692

dmitry-markin opened this issue Jun 4, 2024 · 1 comment
Labels
I3-annoyance The node behaves within expectations, however this “expected behaviour” itself is at issue. T0-node This PR/Issue is related to the topic “node”. T10-tests This PR/Issue is related to tests.

Comments

@dmitry-markin
Copy link
Contributor

libp2p upgrade to v0.52.3 brought new Stream abstraction that has new() method private. This made Notifications tests not compile without possibility to make them work. So, they were commented out in #4682 (see the commit).

This issue is about trying to upstream the patch to libp2p that makes Stream::new() method public and restoring the functionality of Notifications tests.

cc @paritytech/networking

@dmitry-markin dmitry-markin added T0-node This PR/Issue is related to the topic “node”. I3-annoyance The node behaves within expectations, however this “expected behaviour” itself is at issue. T10-tests This PR/Issue is related to tests. labels Jun 4, 2024
@dmitry-markin
Copy link
Contributor Author

Addressed in #1631 using unsafe { } trick.

@github-project-automation github-project-automation bot moved this to Blocked ⛔️ in Networking Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I3-annoyance The node behaves within expectations, however this “expected behaviour” itself is at issue. T0-node This PR/Issue is related to the topic “node”. T10-tests This PR/Issue is related to tests.
Projects
Status: Blocked ⛔️
Development

No branches or pull requests

1 participant