Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test case bench_promote in core-fellowship pallet failed #3845

Closed
2 tasks done
chungquantin opened this issue Mar 26, 2024 · 5 comments
Closed
2 tasks done

Test case bench_promote in core-fellowship pallet failed #3845

chungquantin opened this issue Mar 26, 2024 · 5 comments
Assignees
Labels
I2-bug The node fails to follow expected behavior. T12-benchmarks This PR/Issue is related to benchmarking and weights.

Comments

@chungquantin
Copy link
Contributor

Is there an existing issue?

  • I have searched the existing issues

Experiencing problems? Have you tried our Stack Exchange first?

  • This is not a support question.

Description of bug

See the failed test case below returned with TooSoon

test benchmarking::benchmarks::bench_induct ... ok
test benchmarking::benchmarks::bench_bump_offboard ... ok
test benchmarking::benchmarks::bench_submit_evidence ... ok
test benchmarking::benchmarks::bench_bump_demote ... ok
test benchmarking::benchmarks::bench_approve ... ok
test benchmarking::benchmarks::bench_set_params ... ok
test benchmarking::benchmarks::bench_import ... ok
test benchmarking::benchmarks::bench_set_active ... ok
test benchmarking::benchmarks::bench_offboard ... ok
test tests::integration::test_genesis_config_builds ... ok
+ test benchmarking::benchmarks::bench_promote ... FAILED
test tests::integration::__construct_runtime_integrity_test::runtime_integrity_tests ... ok
test tests::unit::__construct_runtime_integrity_test::runtime_integrity_tests ... ok
test tests::unit::basic_stuff ... ok
test tests::unit::get_salary_works ... ok
test tests::unit::auto_demote_offboard_works ... ok
test tests::unit::auto_demote_works ... ok
test tests::unit::infinite_demotion_period_works ... ok
test tests::integration::swap_bad_noops ... ok
test tests::unit::promote_postpones_auto_demote ... ok
test tests::integration::swap_exhaustive_works ... ok
test tests::unit::induct_works ... ok
test tests::unit::set_partial_params_works ... ok
test tests::unit::set_params_works ... ok
test tests::unit::test_genesis_config_builds ... ok
test tests::unit::sync_works ... ok
test tests::unit::offboard_works ... ok
test tests::unit::proof_postpones_auto_demote ... ok
test tests::unit::active_changing_get_salary_works ... ok
test tests::unit::promote_works ... ok
test tests::integration::swap_simple_works ... ok

failures:

---- benchmarking::benchmarks::bench_promote stdout ----
thread 'benchmarking::benchmarks::bench_promote' panicked at substrate/frame/core-fellowship/src/benchmarking.rs:33:1:
promote: "TooSoon"
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Steps to reproduce

Path: ./substrate/frame/core-fellowship

cargo test --features runtime-benchmarks
@chungquantin chungquantin added I10-unconfirmed Issue might be valid, but it's not yet known. I2-bug The node fails to follow expected behavior. labels Mar 26, 2024
@ggwpez ggwpez added T12-benchmarks This PR/Issue is related to benchmarking and weights. and removed I10-unconfirmed Issue might be valid, but it's not yet known. labels Mar 26, 2024
@ggwpez
Copy link
Member

ggwpez commented Mar 26, 2024

Weird that CI is not catching this...

@chungquantin
Copy link
Contributor Author

I can work on this issue

@ggwpez
Copy link
Member

ggwpez commented Mar 27, 2024

Yea, first have to find out how CI did not catch this.

@ggwpez
Copy link
Member

ggwpez commented Apr 2, 2024

Should be fixed by this #3947

@ggwpez
Copy link
Member

ggwpez commented Apr 2, 2024

Done in #3885

@ggwpez ggwpez closed this as completed Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I2-bug The node fails to follow expected behavior. T12-benchmarks This PR/Issue is related to benchmarking and weights.
Projects
None yet
Development

No branches or pull requests

2 participants