Break up trait Extrinsic into logical components
#3571
Labels
T1-FRAME
This PR/Issue is related to core FRAME, the framework.
Comments
georgepisaltu
added
the
T1-FRAME
|
I can take this up. |
|
I'm actually already working on this issue with a PR to come soon. Are you interested in any of the other related issues created in #2280 ? |
georgepisaltu
added a commit
that referenced
this issue
Aug 9, 2024
Fixes #3571 Built on top of #3685. This PR breaks up `trait Extrinsic` into different self-contained interfaces as follows: - `ExtrinsicLike` for querying the type of extrinsic (signed/unsigned) - `CreateTransaction` for creating a transaction (general) - `CreateSignedTransaction` for creating a signed transaction (old-school) - `CreateInherent` for creating an inherent --------- Signed-off-by: georgepisaltu <[email protected]> Co-authored-by: command-bot <>
gui1117
pushed a commit
to gui1117/polkadot-sdk
that referenced
this issue
Aug 15, 2024
Fixes paritytech#3571 Built on top of paritytech#3685. This PR breaks up `trait Extrinsic` into different self-contained interfaces as follows: - `ExtrinsicLike` for querying the type of extrinsic (signed/unsigned) - `CreateTransaction` for creating a transaction (general) - `CreateSignedTransaction` for creating a signed transaction (old-school) - `CreateInherent` for creating an inherent --------- Signed-off-by: georgepisaltu <[email protected]> Co-authored-by: command-bot <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the context of the introduction of
TransactionExtensions in #2280 , it became clear that theExtrinsicinterface is not fit for the transaction model. Detailed discussion starts here and conclusion is here. To summarize,trait Extrinsicshould identify the type of extrinsic for a given instance (inherent or transaction), while the rest of the functionality currently intrait Extrinsicshould be moved to different traits:CreateTransaction: create a transaction (general), have a type for extensionCreateSignedTransaction: create a signed transaction (old-school), have a type for signature and extension (basically what is now trait CreateSignedTransaction and Extrinsic::SignaturePayload)CreateInherent: create an inherentUncheckedExtrinsicshould still implement all of these. This way users can pick and choose the functionality they need by using only the necessary trait bounds and we provide backwards compatibility.The text was updated successfully, but these errors were encountered: