Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix collation-generation for on-demand/coretime #3327

Closed
alindima opened this issue Feb 14, 2024 · 2 comments
Closed

Fix collation-generation for on-demand/coretime #3327

alindima opened this issue Feb 14, 2024 · 2 comments

Comments

@alindima
Copy link
Contributor

See

polkadot-sdk/polkadot/node/collation-generation/src/lib.rs

Line 239 in 7ec692d

// TODO [now]: this assumes that next up == current.

Very similar to the issue reported in #3141
@alindima alindima mentioned this issue Feb 14, 2024
Closed
@alindima
Copy link
Contributor Author

I think this translates to the collator building an extra candidate when in reality a different para is going to be scheduled next on the core

@alindima alindima mentioned this issue Feb 19, 2024
Merged
3 tasks
@alindima alindima mentioned this issue Mar 18, 2024
Merged
@alindima
Copy link
Contributor Author

Was fixed in #3795

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alindima