Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Deprecation] deprecate "old" weight items #144

Closed
5 of 7 tasks
juangirini opened this issue Jul 28, 2023 · 5 comments · Fixed by #3491
Closed
5 of 7 tasks

[Deprecation] deprecate "old" weight items #144

juangirini opened this issue Jul 28, 2023 · 5 comments · Fixed by #3491
Assignees
@philoniare
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. T1-FRAME This PR/Issue is related to core FRAME, the framework. T13-deprecation The current issue/pr is, or should be, part of a deprecation process.

Comments

@juangirini
Copy link
Contributor

juangirini commented Jul 28, 2023 •
edited
Loading

The deprecated items in frame/support/src/weights.rs need to be removed

Tasks
Beta Give feedback
@Doordashcon
Copy link
Contributor

Hello @juangirini, currently looking into this

@Doordashcon Doordashcon mentioned this issue Aug 3, 2023
Merged
@Doordashcon
Copy link
Contributor

Hello @juangirini, please review

@juangirini juangirini transferred this issue from paritytech/substrate Aug 24, 2023
@the-right-joyce the-right-joyce added C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. T1-FRAME This PR/Issue is related to core FRAME, the framework. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. and removed Z6-mentor labels Aug 25, 2023
@the-right-joyce the-right-joyce added T13-deprecation The current issue/pr is, or should be, part of a deprecation process. and removed I11-deprecation labels Sep 21, 2023
@ggwpez
Copy link
Member

ggwpez commented Feb 5, 2024

sp_weights::OldWeight remains and can now be removed.

@philoniare
Copy link
Contributor

Can I work on this? @ggwpez @juangirini

@ggwpez
Copy link
Member

ggwpez commented Feb 26, 2024

Yea sure 😄

This was referenced Feb 26, 2024
Closed
Merged
github-merge-queue bot pushed a commit that referenced this issue Feb 29, 2024
@philoniare @liamaharon
[Deprecation] Remove sp_weights::OldWeight (#3491)
a22319c 
# Description

*Removes `sp_weights::OldWeight` and its usage*

Fixes #144

---------

Co-authored-by: Liam Aharon <[email protected]>
@github-project-automation github-project-automation bot moved this from In Progress to Done in Runtime / FRAME Feb 29, 2024
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this issue Mar 25, 2024
@philoniare @liamaharon
[Deprecation] Remove sp_weights::OldWeight (paritytech#3491)
ac2b57c 
# Description

*Removes `sp_weights::OldWeight` and its usage*

Fixes paritytech#144

---------

Co-authored-by: Liam Aharon <[email protected]>
lexnv added a commit that referenced this issue Apr 3, 2024
@lexnv
Stabilize transactionWatch to version 1 (#144)
602068f 
* transactionWatch: Stabilize `transactionWatch_v1_submitAndWatch`

Signed-off-by: Alexandru Vasile <[email protected]>

* transactionWatch: Stabilize `transactionWatch_v1_unwatch`

Signed-off-by: Alexandru Vasile <[email protected]>

* txWatch: Solve conflict name with origin

Signed-off-by: Alexandru Vasile <[email protected]>

---------

Signed-off-by: Alexandru Vasile <[email protected]>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@dependabot-preview @serban300
Bump serde from 1.0.112 to 1.0.114 (paritytech#144)
1739493 
Bumps [serde](https://github.com/serde-rs/serde) from 1.0.112 to 1.0.114.
- [Release notes](https://github.com/serde-rs/serde/releases)
- [Commits](serde-rs/serde@v1.0.112...v1.0.114)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@dependabot-preview @serban300
Bump serde from 1.0.112 to 1.0.114 (paritytech#144)
b54ab98 
Bumps [serde](https://github.com/serde-rs/serde) from 1.0.112 to 1.0.114.
- [Release notes](https://github.com/serde-rs/serde/releases)
- [Commits](serde-rs/serde@v1.0.112...v1.0.114)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@dependabot-preview @serban300
Bump serde from 1.0.112 to 1.0.114 (paritytech#144)
fb9bafc 
Bumps [serde](https://github.com/serde-rs/serde) from 1.0.112 to 1.0.114.
- [Release notes](https://github.com/serde-rs/serde/releases)
- [Commits](serde-rs/serde@v1.0.112...v1.0.114)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@dependabot-preview @serban300
Bump serde from 1.0.112 to 1.0.114 (paritytech#144)
f587ba9 
Bumps [serde](https://github.com/serde-rs/serde) from 1.0.112 to 1.0.114.
- [Release notes](https://github.com/serde-rs/serde/releases)
- [Commits](serde-rs/serde@v1.0.112...v1.0.114)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@dependabot-preview @serban300
Bump serde from 1.0.112 to 1.0.114 (paritytech#144)
2080b3e 
Bumps [serde](https://github.com/serde-rs/serde) from 1.0.112 to 1.0.114.
- [Release notes](https://github.com/serde-rs/serde/releases)
- [Commits](serde-rs/serde@v1.0.112...v1.0.114)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@dependabot-preview @serban300
Bump serde from 1.0.112 to 1.0.114 (paritytech#144)
b522390 
Bumps [serde](https://github.com/serde-rs/serde) from 1.0.112 to 1.0.114.
- [Release notes](https://github.com/serde-rs/serde/releases)
- [Commits](serde-rs/serde@v1.0.112...v1.0.114)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@dependabot-preview @serban300
Bump serde from 1.0.112 to 1.0.114 (paritytech#144)
5c37b57 
Bumps [serde](https://github.com/serde-rs/serde) from 1.0.112 to 1.0.114.
- [Release notes](https://github.com/serde-rs/serde/releases)
- [Commits](serde-rs/serde@v1.0.112...v1.0.114)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@dependabot-preview @serban300
Bump serde from 1.0.112 to 1.0.114 (paritytech#144)
8ffb21d 
Bumps [serde](https://github.com/serde-rs/serde) from 1.0.112 to 1.0.114.
- [Release notes](https://github.com/serde-rs/serde/releases)
- [Commits](serde-rs/serde@v1.0.112...v1.0.114)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
@dependabot-preview @serban300
Bump serde from 1.0.112 to 1.0.114 (paritytech#144)
6c622ba 
Bumps [serde](https://github.com/serde-rs/serde) from 1.0.112 to 1.0.114.
- [Release notes](https://github.com/serde-rs/serde/releases)
- [Commits](serde-rs/serde@v1.0.112...v1.0.114)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
@dependabot-preview @serban300
Bump serde from 1.0.112 to 1.0.114 (paritytech#144)
2e054a0 
Bumps [serde](https://github.com/serde-rs/serde) from 1.0.112 to 1.0.114.
- [Release notes](https://github.com/serde-rs/serde/releases)
- [Commits](serde-rs/serde@v1.0.112...v1.0.114)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
jonathanudd pushed a commit to jonathanudd/polkadot-sdk that referenced this issue Apr 10, 2024
@dependabot-preview @bkchr
Bump serde from 1.0.112 to 1.0.114 (paritytech#144)
c005fdd 
Bumps [serde](https://github.com/serde-rs/serde) from 1.0.112 to 1.0.114.
- [Release notes](https://github.com/serde-rs/serde/releases)
- [Commits](serde-rs/serde@v1.0.112...v1.0.114)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philoniare philoniare

Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. T1-FRAME This PR/Issue is related to core FRAME, the framework. T13-deprecation The current issue/pr is, or should be, part of a deprecation process.
Projects
Runtime / FRAME
Status: Done
Milestone
No milestone
6 participants
@gpestana @juangirini @ggwpez @philoniare @Doordashcon @the-right-joyce