From d7d4e0af411b93aa4e55d344820b2d2396b07148 Mon Sep 17 00:00:00 2001
From: Svyatoslav Nikolsky <svyatonik@gmail.com>
Date: Mon, 17 Jul 2023 12:26:09 +0300
Subject: [PATCH] Some code grooming (#2276)

* some code grooming: enable warn(missing_docs) for all piblic crates + added missing documentation + removed obsolete clippy/deny workarounds

* removed strange allow + added comment related to other allow

* removed incorrect_clone_impl_on_copy_type which is unknown to CI clippy
---
 bridges/primitives/runtime/src/lib.rs         | 32 -------------------
 .../primitives/runtime/src/storage_proof.rs   |  4 +--
 2 files changed, 2 insertions(+), 34 deletions(-)

diff --git a/bridges/primitives/runtime/src/lib.rs b/bridges/primitives/runtime/src/lib.rs
index 1c7e153dc6a5..ca709caad7fb 100644
--- a/bridges/primitives/runtime/src/lib.rs
+++ b/bridges/primitives/runtime/src/lib.rs
@@ -457,38 +457,6 @@ macro_rules! generate_static_str_provider {
 	};
 }
 
-/// Error message that is only displayable in `std` environment.
-#[derive(Encode, Decode, Clone, Eq, PartialEq, PalletError, TypeInfo)]
-#[scale_info(skip_type_params(T))]
-pub struct StrippableError<T> {
-	_phantom_data: sp_std::marker::PhantomData<T>,
-	#[codec(skip)]
-	#[cfg(feature = "std")]
-	message: String,
-}
-
-impl<T: Debug> From<T> for StrippableError<T> {
-	fn from(_err: T) -> Self {
-		Self {
-			_phantom_data: Default::default(),
-			#[cfg(feature = "std")]
-			message: format!("{:?}", _err),
-		}
-	}
-}
-
-impl<T> Debug for StrippableError<T> {
-	#[cfg(feature = "std")]
-	fn fmt(&self, f: &mut sp_std::fmt::Formatter<'_>) -> sp_std::fmt::Result {
-		f.write_str(&self.message)
-	}
-
-	#[cfg(not(feature = "std"))]
-	fn fmt(&self, f: &mut sp_std::fmt::Formatter<'_>) -> sp_std::fmt::Result {
-		f.write_str("Stripped error")
-	}
-}
-
 /// A trait defining helper methods for `RangeInclusive` (start..=end)
 pub trait RangeInclusiveExt<Idx> {
 	/// Computes the length of the `RangeInclusive`, checking for underflow and overflow.
diff --git a/bridges/primitives/runtime/src/storage_proof.rs b/bridges/primitives/runtime/src/storage_proof.rs
index f1505e692ef5..48b766fda1df 100644
--- a/bridges/primitives/runtime/src/storage_proof.rs
+++ b/bridges/primitives/runtime/src/storage_proof.rs
@@ -260,13 +260,13 @@ impl VerifiedStorageProof {
 #[cfg(feature = "test-helpers")]
 #[derive(Clone, Copy, Debug, Default)]
 pub struct UnverifiedStorageProofParams {
-	#[allow(missing_docs)]
+	/// Expected storage proof size in bytes.
 	pub db_size: Option<u32>,
 }
 
 #[cfg(feature = "test-helpers")]
 impl UnverifiedStorageProofParams {
-	#[allow(missing_docs)]
+	/// Make storage proof parameters that require proof of at least `db_size` bytes.
 	pub fn from_db_size(db_size: u32) -> Self {
 		Self { db_size: Some(db_size) }
 	}